Updating for svm_poly() engine specific args

Author: juliasilge

R/svm_poly.R

@@ -98,7 +98,8 @@ update.svm_poly <-
            cost = NULL, degree = NULL, scale_factor = NULL, margin = NULL,
            fresh = FALSE,
            ...) {
-    update_dot_check(...)
+
+    eng_args <- update_engine_parameters(object$eng_args, ...)
 
     if (!is.null(parameters)) {
       parameters <- check_final_param(parameters)
@@ -115,12 +116,15 @@ update.svm_poly <-
 
     if (fresh) {
       object$args <- args
+      object$eng_args <- eng_args
     } else {
       null_args <- map_lgl(args, null_value)
       if (any(null_args))
         args <- args[!null_args]
       if (length(args) > 0)
         object$args[names(args)] <- args
+      if (length(eng_args) > 0)
+        object$eng_args[names(eng_args)] <- eng_args
     }
 
     new_model_spec(

tests/testthat/test_svm_poly.R

@@ -80,14 +80,14 @@ test_that('updating', {
   expr1     <- svm_poly(mode = "regression")  %>% set_engine("kernlab", cross = 10)
   expr1_exp <- svm_poly(mode = "regression", degree = 1) %>% set_engine("kernlab", cross = 10)
 
-  expr2     <- svm_poly(mode = "regression", degree = varying()) %>% set_engine("kernlab")
-  expr2_exp <- svm_poly(mode = "regression", degree = varying(), scale_factor = 1) %>% set_engine("kernlab")
+  expr2     <- svm_poly(mode = "regression", degree = varying()) %>% set_engine("kernlab", cross = varying())
+  expr2_exp <- svm_poly(mode = "regression", degree = varying(), scale_factor = 1) %>% set_engine("kernlab", cross = 10)
 
   expr3     <- svm_poly(mode = "regression", degree = 2, scale_factor = varying()) %>% set_engine("kernlab")
   expr3_exp <- svm_poly(mode = "regression", degree = 3) %>% set_engine("kernlab")
 
   expect_equal(update(expr1, degree = 1), expr1_exp)
-  expect_equal(update(expr2,  scale_factor = 1), expr2_exp)
+  expect_equal(update(expr2,  scale_factor = 1, cross = 10), expr2_exp)
   expect_equal(update(expr3, degree = 3, fresh = TRUE), expr3_exp)
 
   param_tibb <- tibble::tibble(degree = 3, cost = 10)