fix formatting in prompt_missing_implementation() (#804)

simonpcouch · topepo · web-flow · commit de7071e07a27 · 2022-09-15T18:26:14.000-04:00
Co-authored-by: Max Kuhn &lt;mxkuhn@gmail.com&gt;
diff --git a/R/misc.R b/R/misc.R
@@ -183,7 +183,7 @@ prompt_missing_implementation <- function(spec,
   msg <- c(
     "!" = "{.pkg parsnip} could not locate an implementation for `{cls}` {mode} \\
            model specifications{if (isTRUE(user_specified_engine)) {
-           ' using the `{engine}` engine' } else {''}}."
+           paste0(' using the `', engine, '` engine')} else {''}}."
     )
 
   if (nrow(avail) == 0 && nrow(all) > 0) {
diff --git a/tests/testthat/_snaps/fit_interfaces.md b/tests/testthat/_snaps/fit_interfaces.md
@@ -12,3 +12,10 @@
     i Please install (if needed) and load to continue.
     
 
+---
+
+    ! parsnip could not locate an implementation for `cubist_rules` model specifications using the `Cubist` engine.
+    i The parsnip extension package rules implements support for this specification.
+    i Please install (if needed) and load to continue.
+    
+
diff --git a/tests/testthat/test_fit_interfaces.R b/tests/testthat/test_fit_interfaces.R
@@ -109,4 +109,5 @@ test_that('No loaded engines', {
   )
   expect_snapshot_error({cubist_rules() %>% fit(mpg ~., data = mtcars)})
   expect_snapshot_error({poisson_reg() %>% fit(mpg ~., data = mtcars)})
+  expect_snapshot_error({cubist_rules(engine = "Cubist") %>% fit(mpg ~., data = mtcars)})
 })

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ prompt_missing_implementation <- function(spec,`
`183`	`183`	`msg <- c(`
`184`	`184`	"!" = "{.pkg parsnip} could not locate an implementation for `{cls}` {mode} \\
`185`	`185`	`model specifications{if (isTRUE(user_specified_engine)) {`
`186`		- ' using the `{engine}` engine' } else {''}}."
	`186`	+ paste0(' using the `', engine, '` engine')} else {''}}."
`187`	`187`	`)`
`188`	`188`
`189`	`189`	`if (nrow(avail) == 0 && nrow(all) > 0) {`
Original file line number	Diff line number	Diff line change
`@@ -109,4 +109,5 @@ test_that('No loaded engines', {`
`109`	`109`	`)`
`110`	`110`	`expect_snapshot_error({cubist_rules() %>% fit(mpg ~., data = mtcars)})`
`111`	`111`	`expect_snapshot_error({poisson_reg() %>% fit(mpg ~., data = mtcars)})`
	`112`	`+ expect_snapshot_error({cubist_rules(engine = "Cubist") %>% fit(mpg ~., data = mtcars)})`
`112`	`113`	`})`