test that call is passed to coerce_ functions

Author: EmilHvitfeldt

DESCRIPTION

@@ -32,7 +32,7 @@ Imports:
     prettyunits,
     purrr (>= 1.0.0),
     rlang (>= 1.1.0),
-    sparsevctrs (>= 0.1.0.9000),
+    sparsevctrs (>= 0.1.0.9002),
     stats,
     tibble (>= 2.1.1),
     tidyr (>= 1.3.0),

R/fit.R

@@ -136,7 +136,7 @@ fit.model_spec <-
 
 
     if (is_sparse_matrix(data)) {
-      data <- sparsevctrs::coerce_to_sparse_tibble(data)
+      data <- sparsevctrs::coerce_to_sparse_tibble(data, rlang::caller_env(0))
     }
 
     dots <- quos(...)

tests/testthat/_snaps/sparsevctrs.md

@@ -30,6 +30,14 @@
       Warning:
       `data` is a sparse tibble, but `linear_reg()` with engine "lm" doesn't accept that. Converting to non-sparse.
 
+---
+
+    Code
+      fit(spec, avg_price_per_room ~ ., data = hotel_data)
+    Condition
+      Error in `fit()`:
+      ! `x` must have column names.
+
 # sparse tibble can be passed to `fit_xy() - unsupported
 
     Code

tests/testthat/test-sparsevctrs.R

@@ -313,3 +313,17 @@ test_that("maybe_sparse_matrix() is used correctly", {
     fit_xy(spec, x = tibble::as_tibble(mtcars)[, -1], y = tibble::as_tibble(mtcars)[, 1])
   )
 })
+
+test_that("fit() errors if sparse matrix has no colnames", {
+  hotel_data <- sparse_hotel_rates()
+  colnames(hotel_data) <- NULL
+
+  spec <- boost_tree() %>%
+    set_mode("regression") %>%
+    set_engine("xgboost")
+
+  expect_snapshot(
+    error = TRUE,
+    fit(spec, avg_price_per_room ~ ., data = hotel_data)
+  )
+})