Skip to content

Commit 9f76423

Browse files
committed
closes #75
1 parent 825c0e3 commit 9f76423

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

docs/articles/articles/Classification.html

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/articles/articles/Scratch.html

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vignettes/articles/Scratch.Rmd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,13 @@ This is a fairly simple function that can follow a basic template. The main argu
9191
* The mode. If the model can do more than one mode, you might default this to "unknown". In our case, since it is only a classification model, it makes sense to default it to that mode.
9292
* The argument names (`subclasses` here). These should be defaulted to `NULL`.
9393
* An argument, `others`, that can be used to pass in other arguments to the underlying model fit functions.
94-
* `...`, although they are not currently used.
94+
* `...`, although they are not currently used. We encourage developers to move the `...` after mode so that users are encouraged to use named arguments to the model specification.
9595

9696
A basic version of the function is:
9797

9898
```{r model-fun}
9999
mixture_da <-
100-
function(mode = "classification", subclasses = NULL, others = list(), ...) {
100+
function(mode = "classification", ..., subclasses = NULL, others = list()) {
101101
102102
# start with some basic error traps
103103
check_empty_ellipse(...)

0 commit comments

Comments
 (0)