Updating for svm_rbf() engine specific args

Author: juliasilge

R/svm_rbf.R

@@ -98,7 +98,8 @@ update.svm_rbf <-
            cost = NULL, rbf_sigma = NULL, margin = NULL,
            fresh = FALSE,
            ...) {
-    update_dot_check(...)
+
+    eng_args <- update_engine_parameters(object$eng_args, ...)
 
     if (!is.null(parameters)) {
       parameters <- check_final_param(parameters)
@@ -114,12 +115,15 @@ update.svm_rbf <-
 
     if (fresh) {
       object$args <- args
+      object$eng_args <- eng_args
     } else {
       null_args <- map_lgl(args, null_value)
       if (any(null_args))
         args <- args[!null_args]
       if (length(args) > 0)
         object$args[names(args)] <- args
+      if (length(eng_args) > 0)
+        object$eng_args[names(eng_args)] <- eng_args
     }
 
     new_model_spec(

tests/testthat/test_svm_rbf.R

@@ -62,11 +62,13 @@ test_that('updating', {
 
   expr1     <- svm_rbf(mode = "regression")  %>% set_engine("kernlab", cross = 10)
   expr1_exp <- svm_rbf(mode = "regression", rbf_sigma = .1) %>% set_engine("kernlab", cross = 10)
-
+  expr2     <- svm_rbf(mode = "regression") %>% set_engine("kernlab", cross = varying())
+  expr2_exp <- svm_rbf(mode = "regression") %>% set_engine("kernlab", cross = 10)
   expr3     <- svm_rbf(mode = "regression", rbf_sigma = .2) %>% set_engine("kernlab")
   expr3_exp <- svm_rbf(mode = "regression", rbf_sigma = .3) %>% set_engine("kernlab")
 
   expect_equal(update(expr1, rbf_sigma = .1), expr1_exp)
+  expect_equal(update(expr2, cross = 10), expr2_exp)
   expect_equal(update(expr3, rbf_sigma = .3, fresh = TRUE), expr3_exp)
 
   param_tibb <- tibble::tibble(rbf_sigma = 3, cost = 10)