Skip to content

Commit 7c5c0bc

Browse files
committed
fit_xy changes and some docs
1 parent cba89be commit 7c5c0bc

File tree

3 files changed

+17
-2
lines changed

3 files changed

+17
-2
lines changed

NEWS.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
# parsnip 0.0.2.9000
2+
3+
## New Features
4+
5+
* `add_rowindex()` can create a column called `.row` to a data frame.
6+
7+
* If a computational engine is not explicitly set, a default will be used. Each default is documented on the corresponding model page. A warning is issued at fit time unless verbosity is zero.
8+
9+
110
# parsnip 0.0.2
211

312
Small release driven by changes in `sample()` in the current r-devel.

R/fit.R

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,13 @@ fit_xy.model_spec <-
186186
...
187187
) {
188188
dots <- quos(...)
189-
if (any(names(dots) == "engine"))
190-
stop("Use `set_engine()` to supply the engine.", call. = FALSE)
189+
if (is.null(object$engine)) {
190+
eng_vals <- possible_engines(object)
191+
object$engine <- eng_vals[1]
192+
if (control$verbosity > 0) {
193+
warning("Engine set to `", object$engine, "`", call. = FALSE)
194+
}
195+
}
191196

192197
if (object$engine != "spark" & NCOL(y) == 1 & !(is.vector(y) | is.factor(y))) {
193198
if (is.matrix(y)) {

_pkgdown.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ reference:
3232
- svm_rbf
3333
- title: Infrastructure
3434
contents:
35+
- add_rowindex
3536
- descriptors
3637
- fit.model_spec
3738
- fit_xy

0 commit comments

Comments
 (0)