Updating for surv_reg() engine specific args

Author: juliasilge

R/surv_reg.R

@@ -96,7 +96,8 @@ print.surv_reg <- function(x, ...) {
 #' @rdname surv_reg
 #' @export
 update.surv_reg <- function(object, parameters = NULL, dist = NULL, fresh = FALSE, ...) {
-  update_dot_check(...)
+
+  eng_args <- update_engine_parameters(object$eng_args, ...)
 
   if (!is.null(parameters)) {
     parameters <- check_final_param(parameters)
@@ -110,12 +111,15 @@ update.surv_reg <- function(object, parameters = NULL, dist = NULL, fresh = FALS
 
   if (fresh) {
     object$args <- args
+    object$eng_args <- eng_args
   } else {
     null_args <- map_lgl(args, null_value)
     if (any(null_args))
       args <- args[!null_args]
     if (length(args) > 0)
       object$args[names(args)] <- args
+    if (length(eng_args) > 0)
+      object$eng_args[names(eng_args)] <- eng_args
   }
 
   new_model_spec(

tests/testthat/test_surv_reg.R

@@ -60,9 +60,9 @@ test_that('engine arguments', {
 
 
 test_that('updating', {
-  expr1     <- surv_reg() %>% set_engine("flexsurv", cl = .99)
+  expr1     <- surv_reg() %>% set_engine("flexsurv", cl = varying())
   expr1_exp <- surv_reg(dist = "lnorm") %>% set_engine("flexsurv", cl = .99)
-  expect_equal(update(expr1, dist = "lnorm"), expr1_exp)
+  expect_equal(update(expr1, dist = "lnorm", cl = 0.99), expr1_exp)
 
   param_tibb <- tibble::tibble(dist = "weibull")
   param_list <- as.list(param_tibb)