Merge pull request #352 from tidymodels/dbl-glmnet-intercept

remove double intercepts for glmnet models

Author: topepo

NEWS.md

@@ -1,9 +1,13 @@
-# parsnip (development version)
+# parsnip 0.1.3
 
  * A `glance()` method for `model_fit` objects was added (#325)
 
  * Specific `tidy()` methods for `glmnet` models fit via `parsnip` were created so that the coefficients for the specific fitted `parsnip` model are returned.
 
+## Fixes
+
+ * `glmnet` models were fitting two intercepts (#349)
+ 
 # parsnip 0.1.2
 
 ## Breaking Changes

R/fit_helpers.R

@@ -63,6 +63,15 @@ xy_xy <- function(object, env, control, target = "none", ...) {
       rlang::abort("For classification models, the outcome should be a factor.")
   }
 
+  encoding_info <-
+    get_encoding(class(object)[1]) %>%
+    dplyr::filter(mode == object$mode, engine == object$engine)
+
+  remove_intercept <- encoding_info %>% dplyr::pull(remove_intercept)
+  if (remove_intercept) {
+    env$x <- env$x[, colnames(env$x) != "(Intercept)", drop = FALSE]
+  }
+
   # if descriptors are needed, update descr_env with the calculated values
   if (requires_descrs(object)) {
     data_stats <- get_descr_xy(env$x, env$y)