Skip to content

Commit 3956848

Browse files
committed
TST be slightly more generic with fit comparison tests
1 parent b873ccb commit 3956848

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

tests/testthat/test_linear_reg_keras.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ ctrl <- fit_control(verbosity = 0, catch = FALSE)
2525
test_that('model fitting', {
2626
skip_on_cran()
2727
skip_if_not_installed("keras")
28-
cmp_slots <- c("lvl", "spec", "fit", "preproc")
2928

3029
set.seed(257)
3130
expect_error(
@@ -50,7 +49,8 @@ test_that('model fitting', {
5049
),
5150
regexp = NA
5251
)
53-
expect_equal(fit1[cmp_slots], fit2[cmp_slots])
52+
fit1$elapsed <- fit2$elapsed
53+
expect_equal(fit1, fit2)
5454

5555
expect_error(
5656
fit(

tests/testthat/test_logistic_reg_keras.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ ctrl <- fit_control(verbosity = 0, catch = FALSE)
4141
test_that('model fitting', {
4242
skip_on_cran()
4343
skip_if_not_installed("keras")
44-
cmp_slots <- c("lvl", "spec", "fit", "preproc")
4544

4645
set.seed(257)
4746
expect_error(
@@ -66,7 +65,8 @@ test_that('model fitting', {
6665
),
6766
regexp = NA
6867
)
69-
expect_equal(fit1[cmp_slots], fit2[cmp_slots])
68+
fit1$elapsed <- fit2$elapsed
69+
expect_equal(fit1, fit2)
7070

7171
expect_error(
7272
fit(

tests/testthat/test_multinom_reg_keras.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ ctrl <- fit_control(verbosity = 0, catch = FALSE)
3434
test_that('model fitting', {
3535
skip_on_cran()
3636
skip_if_not_installed("keras")
37-
cmp_slots <- c("lvl", "spec", "fit", "preproc")
3837

3938
set.seed(257)
4039
expect_error(
@@ -59,7 +58,8 @@ test_that('model fitting', {
5958
),
6059
regexp = NA
6160
)
62-
expect_equal(fit1[cmp_slots], fit2[cmp_slots])
61+
fit1$elapsed <- fit2$elapsed
62+
expect_equal(fit1, fit2)
6363

6464
expect_error(
6565
fit(

0 commit comments

Comments
 (0)