Skip to content

Commit 2752453

Browse files
authored
enable setting stop_iter with brulee mlp() (#1051)
1 parent 948308b commit 2752453

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# parsnip (development version)
22

3+
* Fixed issue in `mlp()` metadata where the `stop_iter` engine argument had been mistakenly protected for the `"brulee"` engine. (#1050)
4+
35
* `.filter_eval_time()` was moved to the survival standalone file.
46

57
* Improved errors and documentation related to special terms in formulas. See `?model_formula` to learn more. (#770, #1014)

R/mlp_data.R

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -433,16 +433,6 @@ set_model_arg(
433433
has_submodel = FALSE
434434
)
435435

436-
437-
set_model_arg(
438-
model = "mlp",
439-
eng = "brulee",
440-
parsnip = "stop_iter",
441-
original = "stop_iter",
442-
func = list(pkg = "dials", fun = "stop_iter"),
443-
has_submodel = FALSE
444-
)
445-
446436
set_model_arg(
447437
model = "mlp",
448438
eng = "brulee",

0 commit comments

Comments
 (0)