Skip to content

Commit 0ff77bc

Browse files
authored
remove registrations for engine arguments (#1054)
* remove registrations for engine arguments * update NEWS entry
1 parent bf3f505 commit 0ff77bc

File tree

5 files changed

+1
-132
lines changed

5 files changed

+1
-132
lines changed

NEWS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
* Fixed bug in fitting some model types with the `"spark"` engine (#1045).
44

5-
* Fixed issue in `mlp()` metadata where the `stop_iter` engine argument had been mistakenly protected for the `"brulee"` engine. (#1050)
5+
* Fixed issues in metadata for the `"brulee"` engine where several arguments were mistakenly protected. (#1050, #1054)
66

77
* `.filter_eval_time()` was moved to the survival standalone file.
88

R/linear_reg_data.R

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -540,44 +540,6 @@ set_model_arg(
540540
has_submodel = FALSE
541541
)
542542

543-
set_model_arg(
544-
model = "linear_reg",
545-
eng = "brulee",
546-
parsnip = "epochs",
547-
original = "epochs",
548-
func = list(pkg = "dials", fun = "epochs"),
549-
has_submodel = FALSE
550-
)
551-
552-
set_model_arg(
553-
model = "linear_reg",
554-
eng = "brulee",
555-
parsnip = "learn_rate",
556-
original = "learn_rate",
557-
func = list(pkg = "dials", fun = "learn_rate"),
558-
has_submodel = FALSE
559-
)
560-
561-
set_model_arg(
562-
model = "linear_reg",
563-
eng = "brulee",
564-
parsnip = "momentum",
565-
original = "momentum",
566-
func = list(pkg = "dials", fun = "momentum"),
567-
has_submodel = FALSE
568-
)
569-
570-
571-
set_model_arg(
572-
model = "linear_reg",
573-
eng = "brulee",
574-
parsnip = "stop_iter",
575-
original = "stop_iter",
576-
func = list(pkg = "dials", fun = "stop_iter"),
577-
has_submodel = FALSE
578-
)
579-
580-
581543
set_fit(
582544
model = "linear_reg",
583545
eng = "brulee",

R/logistic_reg_data.R

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -673,44 +673,6 @@ set_model_arg(
673673
has_submodel = FALSE
674674
)
675675

676-
677-
set_model_arg(
678-
model = "logistic_reg",
679-
eng = "brulee",
680-
parsnip = "epochs",
681-
original = "epochs",
682-
func = list(pkg = "dials", fun = "epochs"),
683-
has_submodel = FALSE
684-
)
685-
686-
set_model_arg(
687-
model = "logistic_reg",
688-
eng = "brulee",
689-
parsnip = "learn_rate",
690-
original = "learn_rate",
691-
func = list(pkg = "dials", fun = "learn_rate"),
692-
has_submodel = FALSE
693-
)
694-
695-
set_model_arg(
696-
model = "logistic_reg",
697-
eng = "brulee",
698-
parsnip = "momentum",
699-
original = "momentum",
700-
func = list(pkg = "dials", fun = "momentum"),
701-
has_submodel = FALSE
702-
)
703-
704-
705-
set_model_arg(
706-
model = "logistic_reg",
707-
eng = "brulee",
708-
parsnip = "stop_iter",
709-
original = "stop_iter",
710-
func = list(pkg = "dials", fun = "stop_iter"),
711-
has_submodel = FALSE
712-
)
713-
714676
set_fit(
715677
model = "logistic_reg",
716678
eng = "brulee",

R/mlp_data.R

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -388,15 +388,6 @@ set_model_arg(
388388
has_submodel = FALSE
389389
)
390390

391-
set_model_arg(
392-
model = "mlp",
393-
eng = "brulee",
394-
parsnip = "mixture",
395-
original = "mixture",
396-
func = list(pkg = "dials", fun = "mixture"),
397-
has_submodel = FALSE
398-
)
399-
400391
set_model_arg(
401392
model = "mlp",
402393
eng = "brulee",
@@ -424,15 +415,6 @@ set_model_arg(
424415
has_submodel = FALSE
425416
)
426417

427-
set_model_arg(
428-
model = "mlp",
429-
eng = "brulee",
430-
parsnip = "momentum",
431-
original = "momentum",
432-
func = list(pkg = "dials", fun = "momentum"),
433-
has_submodel = FALSE
434-
)
435-
436418
set_model_arg(
437419
model = "mlp",
438420
eng = "brulee",

R/multinom_reg_data.R

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -379,43 +379,6 @@ set_model_arg(
379379
has_submodel = FALSE
380380
)
381381

382-
set_model_arg(
383-
model = "multinom_reg",
384-
eng = "brulee",
385-
parsnip = "epochs",
386-
original = "epochs",
387-
func = list(pkg = "dials", fun = "epochs"),
388-
has_submodel = FALSE
389-
)
390-
391-
set_model_arg(
392-
model = "multinom_reg",
393-
eng = "brulee",
394-
parsnip = "learn_rate",
395-
original = "learn_rate",
396-
func = list(pkg = "dials", fun = "learn_rate"),
397-
has_submodel = FALSE
398-
)
399-
400-
set_model_arg(
401-
model = "multinom_reg",
402-
eng = "brulee",
403-
parsnip = "momentum",
404-
original = "momentum",
405-
func = list(pkg = "dials", fun = "momentum"),
406-
has_submodel = FALSE
407-
)
408-
409-
410-
set_model_arg(
411-
model = "multinom_reg",
412-
eng = "brulee",
413-
parsnip = "stop_iter",
414-
original = "stop_iter",
415-
func = list(pkg = "dials", fun = "stop_iter"),
416-
has_submodel = FALSE
417-
)
418-
419382
set_fit(
420383
model = "multinom_reg",
421384
eng = "brulee",

0 commit comments

Comments
 (0)