remove tests for base R error (closes #1193)

Author: simonpcouch

tests/testthat/_snaps/boost_tree.md

@@ -38,14 +38,6 @@
       parsnip::xgb_train(x = missing_arg(), y = missing_arg(), weights = missing_arg(), 
           nthread = 1, verbose = 0)
 
----
-
-    Code
-      translate(boost_tree(formula = y ~ x))
-    Condition
-      Error in `boost_tree()`:
-      ! unused argument (formula = y ~ x)
-
 # check_args() works
 
     Code

tests/testthat/_snaps/decision_tree.md

@@ -34,10 +34,6 @@
     Message
       Used `engine = 'rpart'` for translation.
 
----
-
-    unused argument (formula = y ~ x)
-
 # argument checks for data dimensions
 
     Code

tests/testthat/_snaps/linear_reg.md

@@ -40,30 +40,6 @@
       Error in `translate.default()`:
       ! Please set an engine.
 
----
-
-    Code
-      translate(linear_reg(formula = y ~ x))
-    Condition
-      Error in `linear_reg()`:
-      ! unused argument (formula = y ~ x)
-
----
-
-    Code
-      translate(linear_reg(x = hpc[, 1:3], y = hpc$class) %>% set_engine("glmnet"))
-    Condition
-      Error in `linear_reg()`:
-      ! unused arguments (x = hpc[, 1:3], y = hpc$class)
-
----
-
-    Code
-      translate(linear_reg(formula = y ~ x) %>% set_engine("lm"))
-    Condition
-      Error in `linear_reg()`:
-      ! unused argument (formula = y ~ x)
-
 # lm execution
 
     Code

tests/testthat/_snaps/logistic_reg.md

@@ -23,30 +23,6 @@
       Error in `logistic_reg()`:
       ! "regression" is not a known mode for model `logistic_reg()`.
 
----
-
-    Code
-      translate(logistic_reg(formula = y ~ x))
-    Condition
-      Error in `logistic_reg()`:
-      ! unused argument (formula = y ~ x)
-
----
-
-    Code
-      translate(logistic_reg(x = hpc[, 1:3], y = hpc$class) %>% set_engine(engine = "glmnet"))
-    Condition
-      Error in `logistic_reg()`:
-      ! unused arguments (x = hpc[, 1:3], y = hpc$class)
-
----
-
-    Code
-      translate(logistic_reg(formula = y ~ x) %>% set_engine(engine = "glm"))
-    Condition
-      Error in `logistic_reg()`:
-      ! unused argument (formula = y ~ x)
-
 ---
 
     Code

tests/testthat/_snaps/mars.md

@@ -31,14 +31,6 @@
       x Engine "wat?" is not supported for `mars()`
       i See `show_engines("mars")`.
 
----
-
-    Code
-      translate(mars(formula = y ~ x))
-    Condition
-      Error in `mars()`:
-      ! unused argument (formula = y ~ x)
-
 # mars execution
 
     Code

tests/testthat/_snaps/mlp.md

@@ -51,22 +51,6 @@
       nnet::nnet(formula = missing_arg(), data = missing_arg(), size = 5, 
           trace = FALSE, linout = TRUE)
 
----
-
-    Code
-      translate(mlp(mode = "classification", x = x, y = y) %>% set_engine("keras"))
-    Condition
-      Error in `mlp()`:
-      ! unused arguments (x = x, y = y)
-
----
-
-    Code
-      translate(mlp(mode = "regression", formula = y ~ x) %>% set_engine())
-    Condition
-      Error in `mlp()`:
-      ! unused argument (formula = y ~ x)
-
 # check_args() works
 
     Code

tests/testthat/_snaps/nullmodel.md

@@ -15,14 +15,6 @@
       x Engine "wat?" is not supported for `null_model()`
       i See `show_engines("null_model")`.
 
----
-
-    Code
-      translate(null_model(formula = y ~ x))
-    Condition
-      Error in `null_model()`:
-      ! unused argument (formula = y ~ x)
-
 ---
 
     Code

tests/testthat/_snaps/rand_forest.md

@@ -39,11 +39,3 @@
       x Engine "wat?" is not supported for `rand_forest()`
       i See `show_engines("rand_forest")`.
 
----
-
-    Code
-      translate(rand_forest(mode = "classification", ytest = 2))
-    Condition
-      Error in `rand_forest()`:
-      ! unused argument (ytest = 2)
-

tests/testthat/test-boost_tree.R

@@ -13,7 +13,6 @@ test_that('updating', {
 test_that('bad input', {
   expect_snapshot(error = TRUE, boost_tree(mode = "bogus"))
   expect_snapshot(translate(boost_tree(mode = "classification"), engine = NULL))
-  expect_snapshot(error = TRUE, translate(boost_tree(formula = y ~ x)))
 })
 
 
@@ -49,20 +48,20 @@ test_that('boost_tree can be fit with 1 predictor if validation is used', {
 
 test_that("check_args() works", {
   skip_if_not_installed("xgboost")
-  
+
   expect_snapshot(
     error = TRUE,
     {
-      spec <- boost_tree(trees = -1) %>% 
-        set_engine("xgboost") %>% 
+      spec <- boost_tree(trees = -1) %>%
+        set_engine("xgboost") %>%
         set_mode("classification")
       fit(spec, class ~ ., hpc)
     }
   )
   expect_snapshot(
     error = TRUE,
     {
-      spec <- boost_tree(sample_size = -10) %>% 
+      spec <- boost_tree(sample_size = -10) %>%
         set_engine("xgboost") %>%
         set_mode("classification")
       fit(spec, class ~ ., hpc)
@@ -71,7 +70,7 @@ test_that("check_args() works", {
   expect_snapshot(
     error = TRUE,
     {
-      spec <- boost_tree(tree_depth = -10) %>% 
+      spec <- boost_tree(tree_depth = -10) %>%
         set_engine("xgboost") %>%
         set_mode("classification")
       fit(spec, class ~ ., hpc)
@@ -80,7 +79,7 @@ test_that("check_args() works", {
   expect_snapshot(
     error = TRUE,
     {
-      spec <- boost_tree(min_n = -10) %>% 
+      spec <- boost_tree(min_n = -10) %>%
         set_engine("xgboost") %>%
         set_mode("classification")
       fit(spec, class ~ ., hpc)

tests/testthat/test-decision_tree.R

@@ -23,7 +23,6 @@ test_that('bad input', {
   expect_snapshot(
     try(translate(decision_tree(), engine = NULL), silent = TRUE)
   )
-  expect_snapshot_error(translate(decision_tree(formula = y ~ x)))
 })
 
 test_that('rpart_train is stop-deprecated when it ought to be (#1044)', {