Removing duplicate functions (#27)

* multiple ways of unescaping strings..

from: html.UnescapeString and TibiadataUnescapeStringV3
to: TibiaDataSanitizeEscapedString

* removing TibiadataUnescapeStringV3 func

Author: tobiasehlert

src/TibiaCharactersCharacterV3.go

@@ -1,7 +1,6 @@
 package main
 
 import (
-	"html"
 	"log"
 	"regexp"
 	"strings"
@@ -323,7 +322,7 @@ func TibiaCharactersCharacterV3(c *gin.Context) {
 				if len(subma1a) > 0 {
 
 					// fixing encoding for achievement name
-					subma1a[0][2] = html.UnescapeString(subma1a[0][2])
+					subma1a[0][2] = TibiaDataSanitizeEscapedString(subma1a[0][2])
 
 					// get the name of the achievement (and ignore the secret image on the right)
 					Name := strings.Split(subma1a[0][2], "<img")

src/TibiaFansitesV3.go

@@ -1,7 +1,6 @@
 package main
 
 import (
-	"html"
 	"log"
 	"regexp"
 	"strings"
@@ -148,7 +147,7 @@ func TibiaFansitesV3(c *gin.Context) {
 				}
 
 				// Specials
-				subma1[0][8] = html.UnescapeString(subma1[0][8])
+				subma1[0][8] = TibiaDataSanitizeEscapedString(subma1[0][8])
 				FansiteSpecialsData := strings.Split(subma1[0][8], "</li><li>")
 
 				// FansiteItem & FansiteItemURL

src/TibiaGuildsGuildV3.go

@@ -120,7 +120,7 @@ func TibiaGuildsGuildV3(c *gin.Context) {
 
 			// Abort loop and continue wiht next section
 			if strings.Contains(line, "<br/><br/>") {
-				GuildDescription = TibiadataUnescapeStringV3(GuildDescription)
+				GuildDescription = TibiaDataSanitizeEscapedString(GuildDescription)
 				GuildDescriptionFinished = true
 			}
 
@@ -160,7 +160,7 @@ func TibiaGuildsGuildV3(c *gin.Context) {
 				subma1b := regex1b.FindAllStringSubmatch(line, -1)
 
 				GuildGuildhallData = append(GuildGuildhallData, Guildhall{
-					Name:      TibiadataUnescapeStringV3(subma1b[0][1]),
+					Name:      TibiaDataSanitizeEscapedString(subma1b[0][1]),
 					World:     GuildWorld,
 					PaidUntil: TibiadataDateV3(subma1b[0][2]),
 				})
@@ -213,7 +213,7 @@ func TibiaGuildsGuildV3(c *gin.Context) {
 			}
 
 			MembersData = append(MembersData, Members{
-				Name:     TibiadataUnescapeStringV3(subma1[0][2]),
+				Name:     TibiaDataSanitizeEscapedString(subma1[0][2]),
 				Title:    MembersTitle,
 				Rank:     MembersRank,
 				Vocation: subma1[0][4],

src/TibiaGuildsOverviewV3.go

@@ -76,9 +76,9 @@ func TibiaGuildsOverviewV3(c *gin.Context) {
 
 		if len(subma1) > 0 {
 			OneGuild := Guild{
-				Name:        TibiadataUnescapeStringV3(subma1[0][2]),
+				Name:        TibiaDataSanitizeEscapedString(subma1[0][2]),
 				LogoURL:     subma1[0][1],
-				Description: TibiadataUnescapeStringV3(strings.TrimSpace(subma1[0][4])),
+				Description: TibiaDataSanitizeEscapedString(strings.TrimSpace(subma1[0][4])),
 			}
 
 			// Adding OneWorld to correct category

src/TibiaSpellsOverviewV3.go

@@ -122,7 +122,7 @@ func TibiaSpellsOverviewV3(c *gin.Context) {
 			SpellsData = append(SpellsData, Spell{
 				Name:         subma1[0][2],
 				Spell:        subma1[0][1],
-				Formula:      TibiaDataSanitizeDoubleQuoteString(TibiadataUnescapeStringV3(subma1[0][3])),
+				Formula:      TibiaDataSanitizeDoubleQuoteString(TibiaDataSanitizeEscapedString(subma1[0][3])),
 				Level:        TibiadataStringToIntegerV3(subma1[0][6]),
 				Mana:         TibiadataStringToIntegerV3(subma1[0][7]),
 				Price:        TibiadataStringToIntegerV3(subma1[0][8]),

src/webserver.go

@@ -333,11 +333,6 @@ func TibiadataStringWorldFormatToTitleV3(world string) string {
 	return strings.Title(strings.ToLower(world))
 }
 
-// TibiadataUnescapeStringV3 func
-func TibiadataUnescapeStringV3(data string) string {
-	return html.UnescapeString(data)
-}
-
 // TibiadataQueryEscapeStringV3 func - encode string to be correct formatted
 func TibiadataQueryEscapeStringV3(data string) string {
 	// switching "+" to " "