Skip to content

Commit bbe4736

Browse files
committed
Add guidance on providing alternative solutions in reviews
Encourage reviewers to explain their reasoning and suggest alternatives instead of simply rejecting ideas. This fosters constructive discussions and improves collaboration.
1 parent 3f21788 commit bbe4736

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

code-review/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ Watch a presentation that covers this material from [Derek Prior at RailsConf 20
3030
- **Be explicit**
3131
- Remember people don't always understand your intentions online.
3232

33+
- **When disagreeing, provide alternative solutions**
34+
- Don't simply reject an idea. Explain your reasoning and [suggest alternative
35+
approaches][dont-mcblock-me].
36+
3337
- **Be humble**
3438
- "I'm not sure - let's look it up."
3539

@@ -133,3 +137,4 @@ This helps us have more meaningful conversations on PRs rather than debating per
133137
[challenging to convey emotion and intention online]: https://thoughtbot.com/blog/empathy-online
134138
[using labels]: https://conventionalcomments.org
135139
[standard]: https://github.com/testdouble/standard
140+
[dont-mcblock-me]: https://www.schneems.com/2025/06/03/dont-mcblock-me

0 commit comments

Comments
 (0)