Fix: Correctly filter attributes

Author: thomasthiebaud

src/react.ts

@@ -56,8 +56,12 @@ function transformAttributes(attributes?: Attributes): Attributes {
 
   const transformedAttributes: Attributes = {}
   Object.keys(attributes).forEach((key) => {
-    if (!attributes[key].startsWith('on') && reactAttributesMap[key]) {
-      transformedAttributes[reactAttributesMap[key]] = attributes[key]
+    if (!key.startsWith('on')) {
+      if (reactAttributesMap[key]) {
+        transformedAttributes[reactAttributesMap[key]] = attributes[key]
+      } else {
+        transformedAttributes[key] = attributes[key]
+      }
     }
   })
   return transformedAttributes

tests/api.spec.ts

@@ -1,4 +1,4 @@
-import { render, shallow } from 'enzyme'
+import { render } from 'enzyme'
 import * as React from 'react'
 
 import * as htmldomToReact from '../src/index'
@@ -10,7 +10,7 @@ describe('Public API', () => {
 
   describe('#parse', () => {
     it('should convert a string to an array of react nodes', () => {
-      const elements = htmldomToReact.parse('<em><b>It\' is working</b></em>')
+      const elements = htmldomToReact.parse('<em key="1"><b key="2">It\' is working</b></em>')
       const wrapper = render(React.createElement('div', null, elements))
       expect(wrapper.text()).toEqual('It\' is working')
       expect(wrapper.find('em')).toHaveLength(1)

tests/react.spec.ts

@@ -90,7 +90,13 @@ describe('React', () => {
     it('should render nested tags', () => {
       const element = {
         children: [{
+          attributes: {
+            key: '1',
+          },
           children: [{
+            attributes: {
+              key: '2',
+            },
             name: '#text',
             type: NodeType.TEXT_NODE,
             value: 'text',