Skip to content

Commit 03586f5

Browse files
Breaking: Remove useFragment option
1 parent 813adf0 commit 03586f5

File tree

4 files changed

+4
-24
lines changed

4 files changed

+4
-24
lines changed

src/config.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ export interface DOMConfig {
6565
export interface Config {
6666
dom?: DOMConfig
6767
overrides?: SelectorsToElement,
68-
useFragment?: boolean,
6968
useAsKey?: string[],
7069
}
7170

@@ -89,7 +88,6 @@ const defaultConfig: Config = {
8988
ADD_ATTR: ['key'],
9089
},
9190
useAsKey: ['key'],
92-
useFragment: false,
9391
}
9492

9593
export function getConfig(config?: Partial<Config>): Config {

src/react.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ function transform(element: EnrichedElement, options: Config) {
104104
}
105105
}
106106

107-
export function render(nodes: NodeListOf<Node & ChildNode>, options: Config): React.ReactNode[] | React.ReactFragment {
107+
export function render(nodes: NodeListOf<Node & ChildNode>, options: Config): React.ReactNode[] {
108108
const elements: React.ReactNode[] = []
109109

110110
for (let i = 0; i < nodes.length; i++) {
@@ -117,8 +117,5 @@ export function render(nodes: NodeListOf<Node & ChildNode>, options: Config): Re
117117
}
118118
}
119119

120-
if (options.useFragment) {
121-
return React.createElement(React.Fragment, null, ...elements)
122-
}
123120
return elements
124121
}

tests/config.spec.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ describe('Options', () => {
1212
RETURN_DOM_IMPORT: false,
1313
},
1414
useAsKey: ['key'],
15-
useFragment: false,
1615
})
1716
})
1817

@@ -31,7 +30,6 @@ describe('Options', () => {
3130
RETURN_DOM_IMPORT: false,
3231
},
3332
useAsKey: ['key'],
34-
useFragment: false,
3533
})
3634
})
3735

@@ -49,7 +47,6 @@ describe('Options', () => {
4947
RETURN_DOM_IMPORT: false,
5048
},
5149
useAsKey: ['key'],
52-
useFragment: false,
5350
})
5451
})
5552
})

tests/react.spec.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -65,18 +65,6 @@ describe('React', () => {
6565
})
6666

6767
describe('Options', () => {
68-
describe('#useFragment', () => {
69-
it('should return a Fragment', () => {
70-
const div = document.createElement('div')
71-
const link = document.createElement('a')
72-
link.textContent = 'Link'
73-
div.appendChild(link)
74-
75-
const wrapper = shallowWrapper(render(div.childNodes, { useFragment: true, useAsKey: ['key'] }))
76-
expect(wrapper.find('a').text()).toEqual('Link')
77-
})
78-
})
79-
8068
describe('#useAsKey', () => {
8169
it('should use key as a default key', () => {
8270
const div = document.createElement('div')
@@ -85,7 +73,7 @@ describe('React', () => {
8573
link.setAttribute('key', 'link')
8674
div.appendChild(link)
8775

88-
const wrapper = shallowWrapper(render(div.childNodes, { useFragment: true, useAsKey: ['key'] }))
76+
const wrapper = shallowWrapper(render(div.childNodes, { useAsKey: ['key'] }))
8977
expect(wrapper.find('a').key()).toEqual('link')
9078
})
9179

@@ -96,7 +84,7 @@ describe('React', () => {
9684
link.setAttribute('class', 'fallback key')
9785
div.appendChild(link)
9886

99-
const wrapper = shallowWrapper(render(div.childNodes, { useFragment: true, useAsKey: ['key', 'id', 'class'] }))
87+
const wrapper = shallowWrapper(render(div.childNodes, { useAsKey: ['key', 'id', 'class'] }))
10088
expect(wrapper.find('a').key()).toEqual('fallback key')
10189
})
10290

@@ -106,7 +94,7 @@ describe('React', () => {
10694
link.textContent = 'Link'
10795
div.appendChild(link)
10896

109-
const wrapper = shallowWrapper(render(div.childNodes, { useFragment: true, useAsKey: ['key', 'id'] }))
97+
const wrapper = shallowWrapper(render(div.childNodes, { useAsKey: ['key', 'id'] }))
11098
expect(wrapper.find('a').key()).toEqual(null)
11199
})
112100
})

0 commit comments

Comments
 (0)