fix(ImageLoader): fallback image being loaded when clearing src value from dummy image

Author: edoparearyee

src/app/image-loader/image-loader.component.spec.ts

@@ -194,8 +194,17 @@ describe('ImageLoaderComponent', () => {
 
   it('should load fallback image', () => {
     component.src = '';
+    component.preloadSrc = 'someurl';
     component.onImagePreloadError();
     expect(component.src).toEqual(image.fallback);
   });
 
+  it('should NOT load fallback image', () => {
+    component.src = '';
+    component.preloadSrc = '';
+    component.preloadSrcset = '';
+    component.onImagePreloadError();
+    expect(component.src).toEqual('');
+  });
+
 });

src/app/image-loader/image-loader.component.ts

@@ -300,10 +300,13 @@ export class ImageLoaderComponent implements OnInit, AfterViewInit, OnDestroy {
    * @memberof ImageLoaderComponent
    */
   public onImagePreloadError(): void {
-    this.srcset = '';
-    this.src = this.image.fallback;
-    this.preloadSrc = '';
-    this.loaded = true;
+    if (this.preloadSrc || this.preloadSrcset) {
+      this.srcset = '';
+      this.preloadSrc = '';
+      this.preloadSrcset = '';
+      this.src = this.image.fallback;
+      this.loaded = true;
+    }
   }
   /**
    * When the main `img` element has loaded