Throw on JS exceptions instead of returning default values (#4)

Author: 0xFirekeeper

Assets/Thirdweb/Scripts/Bridge.cs

@@ -90,17 +90,9 @@ public static async Task<T> InvokeRoute<T>(string route, string[] body)
             var task = new TaskCompletionSource<string>();
             taskMap[taskId] = task;
             ThirdwebInvoke(taskId, route, msg, jsCallback);
-            try 
-            {
-                string result = await task.Task;
-                // Debug.LogFormat("Result from {0}: {1}", route, result);
-                return JsonConvert.DeserializeObject<Result<T>>(result).result;
-            } 
-            catch (Exception)
-            {
-                // Debug.LogFormat("Error from {0}: {1}", route, e);
-                return default(T);
-            }
+            string result = await task.Task;
+            Debug.Log($"InvokeRoute Result: {result}");
+            return JsonConvert.DeserializeObject<Result<T>>(result).result;
         }
 
         [DllImport("__Internal")]

Assets/WebGLTemplates/Thirdweb/lib/thirdweb.js

@@ -43,29 +43,21 @@ w.bridge.connect = async () => {
       });
       return await w.thirdweb.wallet.getAddress();
     } else {
-      console.error("window.thirdweb is not defined");
-      return null;
+      throw "window.thirdweb is not defined";
     }
   } else {
-    console.error("Please install a wallet browser extension");
-    return null;
+    throw "Please install a wallet browser extension";
   }
 };
 
 w.bridge.switchNetwork = async (chainId) => {
-  try {
-    if (chainId) {
-      await window.ethereum.request({
-        method: "wallet_switchEthereumChain",
-        params: [{ chainId: "0x" + chainId.toString(16) }],
-      });
-    } else {
-      console.error("Error switrching network");
-      return null;
-    }
-  } catch (e) {
-    console.error("Error switrching network", e);
-    return null;
+  if (chainId) {
+    await window.ethereum.request({
+      method: "wallet_switchEthereumChain",
+      params: [{ chainId: "0x" + chainId.toString(16) }],
+    });
+  } else {
+    throw "Error Switching Network";
   }
 };
 
@@ -94,8 +86,7 @@ w.bridge.invoke = async (route, payload) => {
       const result = await w.thirdweb[prop][routeArgs[1]](...parsedArgs);
       return JSON.stringify({ result: result }, bigNumberReplacer);
     } else {
-      console.error("invalid route", route);
-      return null;
+      throw "Invalid Route";
     }
   }
 
@@ -122,8 +113,7 @@ w.bridge.invoke = async (route, payload) => {
       );
       return JSON.stringify({ result: result }, bigNumberReplacer);
     } else {
-      console.error("invalid route", route);
-      return null;
+      throw "Invalid Route";
     }
   }
 };