Skip to content

Commit dfd9dba

Browse files
Krishang NadgaudaKrishang Nadgauda
authored andcommitted
comments cleanup on ContractMetadataregistry
1 parent b834ef9 commit dfd9dba

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

contracts/ContractMetadataRegistry.sol

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,32 +10,37 @@ import "@openzeppelin/contracts/metatx/ERC2771Context.sol";
1010
import { IContractMetadataRegistry } from "./interfaces/IContractMetadataRegistry.sol";
1111

1212
contract ContractMetadataRegistry is IContractMetadataRegistry, ERC2771Context, Multicall, AccessControlEnumerable {
13+
14+
/// @dev Only accounts with OPERATOR_ROLE can register metadata for contracts.
1315
bytes32 public constant OPERATOR_ROLE = keccak256("OPERATOR_ROLE");
1416

1517
/*///////////////////////////////////////////////////////////////
16-
State variables
18+
Mappings
1719
//////////////////////////////////////////////////////////////*/
1820

1921
/// @dev contract address deployed => metadata uri
2022
mapping(address => string) public getMetadataUri;
2123

2224
/*///////////////////////////////////////////////////////////////
23-
Constructor + modifiers
25+
Constructor
2426
//////////////////////////////////////////////////////////////*/
2527

2628
constructor(address _trustedForwarder) ERC2771Context(_trustedForwarder) {
2729
_setupRole(DEFAULT_ADMIN_ROLE, _msgSender());
2830
}
2931

3032
/*///////////////////////////////////////////////////////////////
31-
External methods
33+
External functions
3234
//////////////////////////////////////////////////////////////*/
3335

36+
/// @dev Records `metadataUri` as metadata for the contract at `contractAddress`.
3437
function registerMetadata(address contractAddress, string memory metadataUri) external {
35-
require(hasRole(OPERATOR_ROLE, _msgSender()), "not operator.");
38+
require(hasRole(OPERATOR_ROLE, _msgSender()), "Not operator.");
3639
require(bytes(metadataUri).length > 0, "No metadata");
3740
require(bytes(getMetadataUri[contractAddress]).length == 0, "Metadata already registered");
41+
3842
getMetadataUri[contractAddress] = metadataUri;
43+
3944
emit MetadataRegistered(contractAddress, metadataUri);
4045
}
4146

contracts/interfaces/IContractMetadataRegistry.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,6 @@ interface IContractMetadataRegistry {
55
/// @dev Emitted when a contract metadata is registered
66
event MetadataRegistered(address indexed contractAddress, string metadataUri);
77

8+
/// @dev Records `metadataUri` as metadata for the contract at `contractAddress`.
89
function registerMetadata(address contractAddress, string memory metadataUri) external;
910
}

docs/ContractMetadataRegistry.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function OPERATOR_ROLE() external view returns (bytes32)
3535

3636

3737

38-
38+
*Only accounts with OPERATOR_ROLE can register metadata for contracts.*
3939

4040

4141
#### Returns
@@ -225,7 +225,7 @@ function registerMetadata(address contractAddress, string metadataUri) external
225225

226226

227227

228-
228+
*Records `metadataUri` as metadata for the contract at `contractAddress`.*
229229

230230
#### Parameters
231231

docs/IContractMetadataRegistry.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function registerMetadata(address contractAddress, string metadataUri) external
1818

1919

2020

21-
21+
*Records `metadataUri` as metadata for the contract at `contractAddress`.*
2222

2323
#### Parameters
2424

0 commit comments

Comments
 (0)