Fix: delete require statement in setMaxTotalSupply (#188)

nkrishang · Krishang Nadgauda · web-flow · commit d90b33787e48 · 2022-07-01T15:01:11.000-07:00
Co-authored-by: Krishang Nadgauda &lt;nkrishang@Krishangs-MBP.lan&gt;
diff --git a/contracts/drop/DropERC20.sol b/contracts/drop/DropERC20.sol
@@ -463,7 +463,6 @@ contract DropERC20 is
 
     /// @dev Lets a contract admin set the global maximum supply of tokens.
     function setMaxTotalSupply(uint256 _maxTotalSupply) external onlyRole(DEFAULT_ADMIN_ROLE) {
-        require(_maxTotalSupply < totalSupply(), "already minted more than desired max supply");
         maxTotalSupply = _maxTotalSupply;
         emit MaxTotalSupplyUpdated(_maxTotalSupply);
     }
diff --git a/contracts/drop/DropERC721.sol b/contracts/drop/DropERC721.sol
@@ -632,7 +632,6 @@ contract DropERC721 is
 
     /// @dev Lets a contract admin set the global maximum supply for collection's NFTs.
     function setMaxTotalSupply(uint256 _maxTotalSupply) external onlyRole(DEFAULT_ADMIN_ROLE) {
-        require(_maxTotalSupply < nextTokenIdToMint, "existing > desired max supply");
         maxTotalSupply = _maxTotalSupply;
         emit MaxTotalSupplyUpdated(_maxTotalSupply);
     }

Original file line number	Diff line number	Diff line change
`@@ -463,7 +463,6 @@ contract DropERC20 is`
`463`	`463`
`464`	`464`	`/// @dev Lets a contract admin set the global maximum supply of tokens.`
`465`	`465`	`function setMaxTotalSupply(uint256 _maxTotalSupply) external onlyRole(DEFAULT_ADMIN_ROLE) {`
`466`		`- require(_maxTotalSupply < totalSupply(), "already minted more than desired max supply");`
`467`	`466`	`maxTotalSupply = _maxTotalSupply;`
`468`	`467`	`emit MaxTotalSupplyUpdated(_maxTotalSupply);`
`469`	`468`	`}`
Original file line number	Diff line number	Diff line change
`@@ -632,7 +632,6 @@ contract DropERC721 is`
`632`	`632`
`633`	`633`	`/// @dev Lets a contract admin set the global maximum supply for collection's NFTs.`
`634`	`634`	`function setMaxTotalSupply(uint256 _maxTotalSupply) external onlyRole(DEFAULT_ADMIN_ROLE) {`
`635`		`- require(_maxTotalSupply < nextTokenIdToMint, "existing > desired max supply");`
`636`	`635`	`maxTotalSupply = _maxTotalSupply;`
`637`	`636`	`emit MaxTotalSupplyUpdated(_maxTotalSupply);`
`638`	`637`	`}`