use caller, not publisher, for registry.add

Author: Krishang Nadgauda

contracts/ByocFactory.sol

@@ -90,12 +90,15 @@ contract ByocFactory is IByocFactory, ERC2771Context, Multicall, AccessControlEn
         uint256 _value,
         string memory publishMetadataUri
     ) external onlyUnpausedOrAdmin returns (address deployedAddress) {
+
+        address caller = _msgSender();
+
         bytes32 salt = _salt == ""
-            ? keccak256(abi.encodePacked(_msgSender(), block.number, _implementation, _initializeData))
-            : keccak256(abi.encodePacked(_msgSender(), _salt));
+            ? keccak256(abi.encodePacked(caller, block.number, _implementation, _initializeData))
+            : keccak256(abi.encodePacked(caller, _salt));
 
         address computedContractAddress = Clones.predictDeterministicAddress(_implementation, salt, address(this));
-        getContractDeployer[computedContractAddress] = _msgSender();
+        getContractDeployer[computedContractAddress] = caller;
 
         deployedAddress = Clones.cloneDeterministic(_implementation, salt);
 
@@ -106,14 +109,14 @@ contract ByocFactory is IByocFactory, ERC2771Context, Multicall, AccessControlEn
             "Not a thirdweb contract"
         );
 
-        registry.add(_publisher, deployedAddress);
+        registry.add(caller, deployedAddress);
 
         if (_initializeData.length > 0) {
             // slither-disable-next-line unused-return
             Address.functionCallWithValue(deployedAddress, _initializeData, _value);
         }
 
-        emit ContractDeployed(_msgSender(), _publisher, deployedAddress);
+        emit ContractDeployed(caller, _publisher, deployedAddress);
     }
 
     /*///////////////////////////////////////////////////////////////

docs/ByocFactory.md

@@ -81,16 +81,21 @@ Deploys a clone pointing to an implementation of a published contract.
 |---|---|---|
 | deployedAddress | address | undefined
 
-### deployer
+### getContractDeployer
 
 ```solidity
-function deployer() external view returns (address)
+function getContractDeployer(address) external view returns (address)
 ```
 
 
 
-*Empty var used in deployment.*
+*contract address deployed through the factory => deployer*
 
+#### Parameters
+
+| Name | Type | Description |
+|---|---|---|
+| _0 | address | undefined
 
 #### Returns
 
@@ -244,6 +249,28 @@ function isTrustedForwarder(address forwarder) external view returns (bool)
 |---|---|---|
 | _0 | bool | undefined
 
+### multicall
+
+```solidity
+function multicall(bytes[] data) external nonpayable returns (bytes[] results)
+```
+
+
+
+*Receives and executes a batch of function calls on this contract.*
+
+#### Parameters
+
+| Name | Type | Description |
+|---|---|---|
+| data | bytes[] | undefined
+
+#### Returns
+
+| Name | Type | Description |
+|---|---|---|
+| results | bytes[] | undefined
+
 ### renounceRole
 
 ```solidity

docs/IContractDeployer.md

@@ -0,0 +1,37 @@
+# IContractDeployer
+
+
+
+
+
+
+
+
+
+## Methods
+
+### getContractDeployer
+
+```solidity
+function getContractDeployer(address _contract) external view returns (address)
+```
+
+
+
+
+
+#### Parameters
+
+| Name | Type | Description |
+|---|---|---|
+| _contract | address | undefined
+
+#### Returns
+
+| Name | Type | Description |
+|---|---|---|
+| _0 | address | undefined
+
+
+
+

docs/ThirdwebContract.md

@@ -46,3 +46,17 @@ function setPublishMetadataUri(string uri) external nonpayable
 
 
 
+## Errors
+
+### ThirdwebContract_MetadataAlreadyInitialized
+
+```solidity
+error ThirdwebContract_MetadataAlreadyInitialized()
+```
+
+
+
+
+
+
+