OpenEditionERC721: expose startTokenId (#410)

* Expose fn startTokenId()

* docs update

* pkg update

* Fix test

Author: nkrishang

contracts/OpenEditionERC721.sol

@@ -119,7 +119,7 @@ contract OpenEditionERC721 is
     /// @dev Returns the URI for a given tokenId.
     function tokenURI(uint256 _tokenId) public view virtual override returns (string memory) {
         if (!_exists(_tokenId)) {
-            revert("OpenCollectionERC721: URI query for nonexistent token.");
+            revert("!ID");
         }
 
         return _getURIFromSharedMetadata(_tokenId);
@@ -141,6 +141,10 @@ contract OpenEditionERC721 is
         return 1;
     }
 
+    function startTokenId() public pure returns (uint256) {
+        return _startTokenId();
+    }
+
     /*///////////////////////////////////////////////////////////////
                         Internal functions
     //////////////////////////////////////////////////////////////*/
@@ -190,9 +194,9 @@ contract OpenEditionERC721 is
     function _transferTokensOnClaim(address _to, uint256 _quantityBeingClaimed)
         internal
         override
-        returns (uint256 startTokenId)
+        returns (uint256 startTokenId_)
     {
-        startTokenId = _currentIndex;
+        startTokenId_ = _currentIndex;
         _safeMint(_to, _quantityBeingClaimed);
     }
 
@@ -269,15 +273,15 @@ contract OpenEditionERC721 is
     function _beforeTokenTransfers(
         address from,
         address to,
-        uint256 startTokenId,
+        uint256 startTokenId_,
         uint256 quantity
     ) internal virtual override {
-        super._beforeTokenTransfers(from, to, startTokenId, quantity);
+        super._beforeTokenTransfers(from, to, startTokenId_, quantity);
 
         // if transfer is restricted on the contract, we still want to allow burning and minting
         if (!hasRole(transferRole, address(0)) && from != address(0) && to != address(0)) {
             if (!hasRole(transferRole, from) && !hasRole(transferRole, to)) {
-                revert("!Transfer-Role");
+                revert("!T");
             }
         }
     }

contracts/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@thirdweb-dev/contracts",
   "description": "Collection of smart contracts deployable via the thirdweb SDK, dashboard and CLI",
-  "version": "3.5.7",
+  "version": "3.5.8",
   "license": "Apache-2.0",
   "repository": {
     "type": "git",

docs/OpenEditionERC721.md

@@ -976,6 +976,23 @@ Token metadata information
 | imageURI | string | undefined |
 | animationURI | string | undefined |
 
+### startTokenId
+
+```solidity
+function startTokenId() external pure returns (uint256)
+```
+
+
+
+
+
+
+#### Returns
+
+| Name | Type | Description |
+|---|---|---|
+| _0 | uint256 | undefined |
+
 ### subscribeToRegistry
 
 ```solidity

src/test/OpenEditionERC721.t.sol

@@ -254,7 +254,7 @@ contract OpenEditionERC721Test is BaseTest {
         vm.prank(deployer);
         openEdition.revokeRole(keccak256("TRANSFER_ROLE"), address(0));
         vm.startPrank(receiver);
-        vm.expectRevert(("!Transfer-Role"));
+        vm.expectRevert(bytes("!T"));
         openEdition.transferFrom(receiver, address(123), 1);
     }