Skip to content

Commit 66b964e

Browse files
Krishang NadgaudaKrishang Nadgauda
authored andcommitted
override all functions coming from interfaces
1 parent 2284362 commit 66b964e

12 files changed

+20
-13
lines changed

contracts/feature/DelayedReveal.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ abstract contract DelayedReveal is IDelayedReveal {
2121
}
2222

2323
/// @dev See: https://ethereum.stackexchange.com/questions/69825/decrypt-message-on-chain
24-
function encryptDecrypt(bytes memory data, bytes calldata key) public pure returns (bytes memory result) {
24+
function encryptDecrypt(bytes memory data, bytes calldata key) public pure override returns (bytes memory result) {
2525
// Store data length on stack for later use
2626
uint256 length = data.length;
2727

contracts/feature/DropSinglePhase.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ abstract contract DropSinglePhase is IDropSinglePhase {
4646
uint256 _pricePerToken,
4747
AllowlistProof calldata _allowlistProof,
4848
bytes memory _data
49-
) public payable virtual {
49+
) public payable virtual override {
5050
_beforeClaim(_receiver, _quantity, _currency, _pricePerToken, _allowlistProof, _data);
5151

5252
bytes32 activeConditionId = conditionId;
@@ -98,7 +98,7 @@ abstract contract DropSinglePhase is IDropSinglePhase {
9898
ClaimCondition calldata _condition,
9999
bool _resetClaimEligibility,
100100
bytes memory
101-
) external {
101+
) external virtual override {
102102
bytes32 targetConditionId = conditionId;
103103
uint256 supplyClaimedAlready = claimCondition.supplyClaimed;
104104

contracts/feature/PlatformFee.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ abstract contract PlatformFee is IPlatformFee {
1111
uint16 private platformFeeBps;
1212

1313
/// @dev Returns the platform fee recipient and bps.
14-
function getPlatformFeeInfo() public view returns (address, uint16) {
14+
function getPlatformFeeInfo() public view override returns (address, uint16) {
1515
return (platformFeeRecipient, uint16(platformFeeBps));
1616
}
1717

1818
/// @dev Lets a contract admin update the platform fee recipient and bps
19-
function setPlatformFeeInfo(address _platformFeeRecipient, uint256 _platformFeeBps) public {
19+
function setPlatformFeeInfo(address _platformFeeRecipient, uint256 _platformFeeBps) public override{
2020
require(_canSetPlatformFeeInfo(), "Not authorized");
2121
require(_platformFeeBps <= 10_000, "Exceeds max bps");
2222

contracts/feature/PrimarySale.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ abstract contract PrimarySale is IPrimarySale {
77
/// @dev The address that receives all primary sales value.
88
address private recipient;
99

10-
function primarySaleRecipient() public view returns (address) {
10+
function primarySaleRecipient() public view override returns (address) {
1111
return recipient;
1212
}
1313

1414
/// @dev Lets a contract admin set the recipient for all primary sales.
15-
function setPrimarySaleRecipient(address _saleRecipient) public {
15+
function setPrimarySaleRecipient(address _saleRecipient) public override{
1616
require(_canSetPrimarySaleRecipient(), "Not authorized");
1717

1818
recipient = _saleRecipient;

contracts/feature/Royalty.sol

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ abstract contract Royalty is IRoyalty {
1818
external
1919
view
2020
virtual
21+
override
2122
returns (address receiver, uint256 royaltyAmount)
2223
{
2324
(address recipient, uint256 bps) = getRoyaltyInfoForToken(tokenId);
@@ -26,7 +27,7 @@ abstract contract Royalty is IRoyalty {
2627
}
2728

2829
/// @dev Returns the royalty recipient and bps for a particular token Id.
29-
function getRoyaltyInfoForToken(uint256 _tokenId) public view returns (address, uint16) {
30+
function getRoyaltyInfoForToken(uint256 _tokenId) public view override returns (address, uint16) {
3031
RoyaltyInfo memory royaltyForToken = royaltyInfoForToken[_tokenId];
3132

3233
return
@@ -36,12 +37,12 @@ abstract contract Royalty is IRoyalty {
3637
}
3738

3839
/// @dev Returns the default royalty recipient and bps.
39-
function getDefaultRoyaltyInfo() external view returns (address, uint16) {
40+
function getDefaultRoyaltyInfo() external view override returns (address, uint16) {
4041
return (royaltyRecipient, uint16(royaltyBps));
4142
}
4243

4344
/// @dev Lets a contract admin update the default royalty recipient and bps.
44-
function setDefaultRoyaltyInfo(address _royaltyRecipient, uint256 _royaltyBps) public {
45+
function setDefaultRoyaltyInfo(address _royaltyRecipient, uint256 _royaltyBps) public override {
4546
require(_canSetRoyaltyInfo(), "Not authorized");
4647
require(_royaltyBps <= 10_000, "Exceeds max bps");
4748

@@ -56,7 +57,7 @@ abstract contract Royalty is IRoyalty {
5657
uint256 _tokenId,
5758
address _recipient,
5859
uint256 _bps
59-
) external {
60+
) external override {
6061
require(_canSetRoyaltyInfo(), "Not authorized");
6162
require(_bps <= 10_000, "Exceeds max bps");
6263

contracts/feature/SignatureMintERC1155.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ abstract contract SignatureMintERC1155 is EIP712, ISignatureMintERC1155 {
2323
function verify(MintRequest calldata _req, bytes calldata _signature)
2424
public
2525
view
26+
override
2627
returns (bool success, address signer)
2728
{
2829
signer = _recoverAddress(_req, _signature);

contracts/feature/SignatureMintERC1155Upgradeable.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ abstract contract SignatureMintERC1155Upgradeable is Initializable, EIP712Upgrad
2727
function verify(MintRequest calldata _req, bytes calldata _signature)
2828
public
2929
view
30+
override
3031
returns (bool success, address signer)
3132
{
3233
signer = _recoverAddress(_req, _signature);

contracts/feature/SignatureMintERC20.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ abstract contract SignatureMintERC20 is EIP712, ISignatureMintERC20 {
2323
function verify(MintRequest calldata _req, bytes calldata _signature)
2424
public
2525
view
26+
override
2627
returns (bool success, address signer)
2728
{
2829
signer = _recoverAddress(_req, _signature);

contracts/feature/SignatureMintERC20Upgradeable.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ abstract contract SignatureMintERC20Upgradeable is Initializable, EIP712Upgradea
2727
function verify(MintRequest calldata _req, bytes calldata _signature)
2828
public
2929
view
30+
override
3031
returns (bool success, address signer)
3132
{
3233
signer = _recoverAddress(_req, _signature);

contracts/feature/SignatureMintERC721.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ abstract contract SignatureMintERC721 is EIP712, ISignatureMintERC721 {
2323
function verify(MintRequest calldata _req, bytes calldata _signature)
2424
public
2525
view
26+
override
2627
returns (bool success, address signer)
2728
{
2829
signer = _recoverAddress(_req, _signature);

0 commit comments

Comments
 (0)