build: address pedantic clippy warnings

Author: brianheineman

postgresql_archive/src/version.rs

@@ -268,7 +268,7 @@ mod tests {
 
     #[test]
     fn test_version_deserialize_parse_error() {
-        assert!(serde_json::from_str::<Version>("\"foo\"").is_err())
+        assert!(serde_json::from_str::<Version>("\"foo\"").is_err());
     }
 
     //

postgresql_commands/src/clusterdb.rs

@@ -4,7 +4,7 @@ use std::convert::AsRef;
 use std::ffi::{OsStr, OsString};
 use std::path::PathBuf;
 
-/// clusterdb clusters all previously clustered tables in a database.
+/// `clusterdb` clusters all previously clustered tables in a database.
 #[derive(Clone, Debug, Default)]
 pub struct ClusterDbBuilder {
     program_dir: Option<PathBuf>,
@@ -252,7 +252,7 @@ mod tests {
         assert_eq!(
             r#"PGPASSWORD="password" "./clusterdb" "--host" "localhost" "--port" "5432" "--username" "postgres""#,
             command.to_command_string()
-        )
+        );
     }
 
     #[test]

postgresql_commands/src/createdb.rs

@@ -4,7 +4,7 @@ use std::convert::AsRef;
 use std::ffi::{OsStr, OsString};
 use std::path::PathBuf;
 
-/// createdb creates a PostgreSQL database.
+/// `createdb` creates a PostgreSQL database.
 #[derive(Clone, Debug, Default)]
 pub struct CreateDbBuilder {
     program_dir: Option<PathBuf>,
@@ -349,7 +349,7 @@ mod tests {
         assert_eq!(
             r#"PGPASSWORD="password" "./createdb" "--host" "localhost" "--port" "5432" "--username" "postgres""#,
             command.to_command_string()
-        )
+        );
     }
 
     #[test]

postgresql_commands/src/createuser.rs

@@ -4,7 +4,7 @@ use std::convert::AsRef;
 use std::ffi::{OsStr, OsString};
 use std::path::PathBuf;
 
-/// createuser creates a new PostgreSQL role.
+/// `createuser` creates a new PostgreSQL role.
 #[derive(Clone, Debug, Default)]
 pub struct CreateUserBuilder {
     program_dir: Option<PathBuf>,
@@ -419,7 +419,7 @@ mod tests {
         assert_eq!(
             r#"PGPASSWORD="password" "./createuser" "--host" "localhost" "--port" "5432" "--username" "postgres""#,
             command.to_command_string()
-        )
+        );
     }
 
     #[test]

postgresql_commands/src/dropdb.rs

@@ -3,7 +3,7 @@ use crate::Settings;
 use std::ffi::{OsStr, OsString};
 use std::path::PathBuf;
 
-/// dropdb removes a PostgreSQL database.
+/// `dropdb` removes a PostgreSQL database.
 #[derive(Clone, Debug, Default)]
 pub struct DropDbBuilder {
     program_dir: Option<PathBuf>,
@@ -238,7 +238,7 @@ mod tests {
         assert_eq!(
             r#"PGPASSWORD="password" "./dropdb" "--host" "localhost" "--port" "5432" "--username" "postgres""#,
             command.to_command_string()
-        )
+        );
     }
 
     #[test]

postgresql_commands/src/dropuser.rs

@@ -4,7 +4,7 @@ use std::convert::AsRef;
 use std::ffi::{OsStr, OsString};
 use std::path::PathBuf;
 
-/// dropuser removes a PostgreSQL role.
+/// `dropuser` removes a PostgreSQL role.
 #[derive(Clone, Debug, Default)]
 pub struct DropUserBuilder {
     program_dir: Option<PathBuf>,
@@ -205,7 +205,7 @@ mod tests {
         assert_eq!(
             r#"PGPASSWORD="password" "./dropuser" "--host" "localhost" "--port" "5432" "--username" "postgres""#,
             command.to_command_string()
-        )
+        );
     }
 
     #[test]

postgresql_commands/src/ecpg.rs

@@ -4,7 +4,7 @@ use std::convert::AsRef;
 use std::ffi::{OsStr, OsString};
 use std::path::PathBuf;
 
-/// ecpg is the PostgreSQL embedded SQL preprocessor for C programs.
+/// `ecpg` is the PostgreSQL embedded SQL preprocessor for C programs.
 #[derive(Clone, Debug, Default)]
 pub struct EcpgBuilder {
     program_dir: Option<PathBuf>,
@@ -203,8 +203,9 @@ mod tests {
     #[test]
     fn test_builder_from() {
         let command = EcpgBuilder::from(&TestSettings).build();
-        assert_eq!(r#""./ecpg""#, command.to_command_string())
+        assert_eq!(r#""./ecpg""#, command.to_command_string());
     }
+
     #[test]
     fn test_builder() {
         let command = EcpgBuilder::new()

postgresql_commands/src/initdb.rs

@@ -4,7 +4,7 @@ use std::convert::AsRef;
 use std::ffi::{OsStr, OsString};
 use std::path::PathBuf;
 
-/// initdb initializes a PostgreSQL database cluster.
+/// `initdb` initializes a PostgreSQL database cluster.
 #[derive(Clone, Debug, Default)]
 pub struct InitDbBuilder {
     program_dir: Option<PathBuf>,
@@ -478,7 +478,7 @@ mod tests {
         assert_eq!(
             r#""./initdb" "--username" "postgres""#,
             command.to_command_string()
-        )
+        );
     }
 
     #[test]

postgresql_commands/src/lib.rs

@@ -1,5 +1,5 @@
-#![allow(async_fn_in_trait)]
 #![forbid(unsafe_code)]
+#![allow(async_fn_in_trait)]
 
 //! Command builders for interacting with PostgreSQL via CLI.
 //!

postgresql_commands/src/oid2name.rs

@@ -4,7 +4,7 @@ use std::convert::AsRef;
 use std::ffi::{OsStr, OsString};
 use std::path::PathBuf;
 
-/// oid2name helps to examine the file structure used by PostgreSQL.
+/// `oid2name` helps to examine the file structure used by PostgreSQL.
 #[derive(Clone, Debug, Default)]
 pub struct Oid2NameBuilder {
     program_dir: Option<PathBuf>,
@@ -234,7 +234,7 @@ mod tests {
         assert_eq!(
             r#""./oid2name" "--host" "localhost" "--port" "5432" "--username" "postgres""#,
             command.to_command_string()
-        )
+        );
     }
 
     #[test]