File tree Expand file tree Collapse file tree 2 files changed +2
-28
lines changed Expand file tree Collapse file tree 2 files changed +2
-28
lines changed Load Diff This file was deleted.
Original file line number Diff line number Diff line change @@ -148,9 +148,7 @@ impl CommandExecutor for std::process::Command {
148148 let status: ExitStatus ;
149149
150150 if OS == "windows" && program. as_str ( ) . ends_with ( "pg_ctl" ) {
151- // TODO: Processes can hang on Windows when attempting to get stdout/stderr using code
152- // that works for Linux/MacOS; this implementation should be updated to retrieve the
153- // values of stdout/stderr without hanging
151+ // The pg_ctl process can hang on Windows when attempting to get stdout/stderr.
154152 let mut process = self
155153 . stdout ( std:: process:: Stdio :: piped ( ) )
156154 . stderr ( std:: process:: Stdio :: piped ( ) )
@@ -194,9 +192,7 @@ impl AsyncCommandExecutor for tokio::process::Command {
194192 let stderr: String ;
195193
196194 if OS == "windows" && program. as_str ( ) . ends_with ( "pg_ctl" ) {
197- // TODO: Processes can hang on Windows when attempting to get stdout/stderr using code
198- // that works for Linux/MacOS; this implementation should be updated to retrieve the
199- // values of stdout/stderr without hanging
195+ // The pg_ctl process can hang on Windows when attempting to get stdout/stderr.
200196 stdout = String :: new ( ) ;
201197 stderr = String :: new ( ) ;
202198 } else {
You can’t perform that action at this time.
0 commit comments