refactor!: remove archive hash from the public interface and always calculate/verify the has when requesting an archive

Author: brianheineman

postgresql_archive/tests/archive.rs

@@ -1,18 +1,11 @@
 #[allow(deprecated)]
 use postgresql_archive::{extract, Version, LATEST, V12, V13, V14, V15, V16};
 use postgresql_archive::{get_archive, get_archive_for_target, get_version};
-use sha2::{Digest, Sha256};
 use std::fs::{create_dir_all, remove_dir_all};
 use test_log::test;
 
 async fn test_get_archive_for_version_constant(version: Version) -> anyhow::Result<()> {
-    let (_, archive, hash) = get_archive(&version).await?;
-
-    let mut hasher = Sha256::new();
-    hasher.update(&archive);
-    let archive_hash = hex::encode(&hasher.finalize());
-
-    assert_eq!(archive_hash, hash);
+    let (_archive_version, _archive) = get_archive(&version).await?;
     Ok(())
 }
 
@@ -69,13 +62,8 @@ async fn test_get_version() -> anyhow::Result<()> {
 #[test(tokio::test)]
 async fn test_get_archive_and_extract() -> anyhow::Result<()> {
     let version = &LATEST;
-    let (archive_version, archive, hash) = get_archive(version).await?;
+    let (archive_version, archive) = get_archive(version).await?;
 
-    let mut hasher = Sha256::new();
-    hasher.update(&archive);
-    let archive_hash = hex::encode(&hasher.finalize());
-
-    assert_eq!(archive_hash, hash);
     assert!(archive_version.matches(version));
 
     let out_dir = tempfile::tempdir()?.path().to_path_buf();
@@ -112,14 +100,9 @@ async fn test_get_archive_for_target_target_not_found() -> postgresql_archive::R
 #[test(tokio::test)]
 async fn test_get_archive_for_target() -> anyhow::Result<()> {
     let version = &LATEST;
-    let (archive_version, archive, hash) =
+    let (archive_version, _archive) =
         get_archive_for_target(version, target_triple::TARGET).await?;
 
-    let mut hasher = Sha256::new();
-    hasher.update(&archive);
-    let archive_hash = hex::encode(&hasher.finalize());
-
-    assert_eq!(archive_hash, hash);
     assert!(archive_version.matches(version));
 
     Ok(())

postgresql_archive/tests/blocking.rs

@@ -3,8 +3,6 @@ use postgresql_archive::blocking::{extract, get_archive, get_archive_for_target,
 #[cfg(feature = "blocking")]
 use postgresql_archive::LATEST;
 #[cfg(feature = "blocking")]
-use sha2::{Digest, Sha256};
-#[cfg(feature = "blocking")]
 use std::fs::{create_dir_all, remove_dir_all};
 #[cfg(feature = "blocking")]
 use test_log::test;
@@ -31,13 +29,8 @@ fn test_get_version() -> anyhow::Result<()> {
 #[allow(deprecated)]
 fn test_get_archive_and_extract() -> anyhow::Result<()> {
     let version = &LATEST;
-    let (archive_version, archive, hash) = get_archive(version)?;
-
-    let mut hasher = Sha256::new();
-    hasher.update(&archive);
-    let archive_hash = hex::encode(&hasher.finalize());
+    let (archive_version, archive) = get_archive(version)?;
 
-    assert_eq!(archive_hash, hash);
     assert!(archive_version.matches(version));
 
     let out_dir = tempfile::tempdir()?.path().to_path_buf();
@@ -53,13 +46,8 @@ fn test_get_archive_and_extract() -> anyhow::Result<()> {
 #[allow(deprecated)]
 fn test_get_archive_for_target() -> anyhow::Result<()> {
     let version = &LATEST;
-    let (archive_version, archive, hash) = get_archive_for_target(version, target_triple::TARGET)?;
-
-    let mut hasher = Sha256::new();
-    hasher.update(&archive);
-    let archive_hash = hex::encode(&hasher.finalize());
+    let (archive_version, _archive) = get_archive_for_target(version, target_triple::TARGET)?;
 
-    assert_eq!(archive_hash, hash);
     assert!(archive_version.matches(version));
 
     Ok(())