fix: create extract_dir on same filesystem as out_dir

jcrossley3 · jcrossley3 · commit 2253a4045370 · 2024-04-29T14:26:08.000-04:00
Otherwise, fs::rename will fail if extract_dir and out_dir are on
different filesystems.

Signed-off-by: Jim Crossley &lt;jim@crossleys.org&gt;
diff --git a/postgresql_archive/src/archive.rs b/postgresql_archive/src/archive.rs
@@ -349,9 +349,7 @@ pub async fn extract(bytes: &Bytes, out_dir: &Path) -> Result<()> {
         return Ok(());
     }
 
-    let extract_dir = tempfile::tempdir()?.into_path();
-    create_dir_all(&extract_dir)?;
-
+    let extract_dir = tempfile::tempdir_in(parent_dir)?.into_path();
     debug!("Extracting archive to {}", extract_dir.to_string_lossy());
 
     for archive_entry in archive.entries()? {

Original file line number	Diff line number	Diff line change
`@@ -349,9 +349,7 @@ pub async fn extract(bytes: &Bytes, out_dir: &Path) -> Result<()> {`
`349`	`349`	`return Ok(());`
`350`	`350`	`}`
`351`	`351`
`352`		`- let extract_dir = tempfile::tempdir()?.into_path();`
`353`		`- create_dir_all(&extract_dir)?;`
`354`		`-`
	`352`	`+ let extract_dir = tempfile::tempdir_in(parent_dir)?.into_path();`
`355`	`353`	`debug!("Extracting archive to {}", extract_dir.to_string_lossy());`
`356`	`354`
`357`	`355`	`for archive_entry in archive.entries()? {`