Merge pull request #125 from academe/master

Support isSuccessful() in acceptNotification

Author: judgej

src/Message/Response.php

@@ -15,17 +15,6 @@ class Response extends AbstractResponse implements RedirectResponseInterface, Co
 {
     use ResponseFieldsTrait;
 
-    /**
-     * @return bool True if the transaction is successful and complete.
-     */
-    public function isSuccessful()
-    {
-        return $this->getStatus() === static::SAGEPAY_STATUS_OK
-            || $this->getStatus() === static::SAGEPAY_STATUS_OK_REPEATED
-            || $this->getStatus() === static::SAGEPAY_STATUS_REGISTERED
-            || $this->getStatus() === static::SAGEPAY_STATUS_AUTHENTICATED;
-    }
-
     /**
      * Gateway Reference
      *

src/Traits/ResponseFieldsTrait.php

@@ -23,6 +23,17 @@ protected function getDataItem($name, $default = null)
         return isset($this->data[$name]) ? $this->data[$name] : $default;
     }
 
+    /**
+     * @return bool True if the transaction is successful and complete.
+     */
+    public function isSuccessful()
+    {
+        return $this->getStatus() === static::SAGEPAY_STATUS_OK
+            || $this->getStatus() === static::SAGEPAY_STATUS_OK_REPEATED
+            || $this->getStatus() === static::SAGEPAY_STATUS_REGISTERED
+            || $this->getStatus() === static::SAGEPAY_STATUS_AUTHENTICATED;
+    }
+
     /**
      * Get the cardReference generated when creating a card reference
      * during an authorisation or payment, or as an explicit request.

tests/Message/ServerNotifyRequestTest.php

@@ -100,6 +100,12 @@ public function testServerNotifyResponseSuccess()
             "Status=OK\r\nRedirectUrl=https://www.example.com/\r\nStatusDetail=detail"
         );
         $this->request->confirm('https://www.example.com/', 'detail');
+
+        // Issue https://github.com/thephpleague/omnipay-sagepay/issues/124
+        // The isSuccessful() method is moved to the trait that shares many
+        // common response fields with the notification server request.
+
+        $this->assertTrue($this->request->isSuccessful());
     }
 
     public function testServerNotifyRequestFailure()