Skip to content

Commit 2160b5c

Browse files
committed
SOme clarification comments.
1 parent ab4ce39 commit 2160b5c

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

composer.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@
1919
"name": "Adrian Macneil",
2020
"email": "adrian@adrianmacneil.com"
2121
},
22+
{
23+
"name": "Jason Judge",
24+
"email": "jason.judge@academe.co.uk"
25+
},
2226
{
2327
"name": "Omnipay Contributors",
2428
"homepage": "https://github.com/thephpleague/omnipay-sagepay/contributors"

src/Message/Form/CompleteAuthorizeRequest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public function getTxType()
3333
public function getData()
3434
{
3535
// The application has the option of passing the query parameter
36-
// in, perhaps using its own middleware, or allowing Omnipay t0
36+
// in, perhaps using its own middleware, or allowing Omnipay to
3737
// provide it.
3838

3939
$crypt = $this->getCrypt() ?: $this->httpRequest->query->get('crypt');
@@ -45,7 +45,7 @@ public function getData()
4545
}
4646

4747
// Remove the leading '@' and decrypt the remainder into a query string.
48-
// And E_WARNING error will be issued if the crypt parameter data is not
48+
// An InvalidResponseException is thrown if the crypt parameter data is not
4949
// a hexadecimal string.
5050

5151
$hexString = substr($crypt, 1);
@@ -64,6 +64,9 @@ public function getData()
6464

6565
parse_str($queryString, $data);
6666

67+
// The result will be ASCII data only, being a very restricted set of
68+
// IDs and flags, so can be treated as UTF-8 without any conversion.
69+
6770
return($data);
6871
}
6972

0 commit comments

Comments
 (0)