Dev snapshot while working on tests (time for bed)

Author: judgej

tests/DPMGatewayTest.php

@@ -35,6 +35,10 @@ public function testAuthorize()
         $this->assertSame('https://www.example.com/return', $redirectData['x_relay_url']);
     }
 
+    /**
+     * The MD4 Hash consists of the shared secret, the login ID, the transaction *reference* (as
+     * generated on the remote gateway for the transaction) and the amount.
+     */
     public function testCompleteAuthorize()
     {
         $this->getHttpRequest()->request->replace(
@@ -53,6 +57,30 @@ public function testCompleteAuthorize()
         $this->assertNull($response->getMessage());
     }
 
+    /**
+     * @expectedException Omnipay\Common\Exception\InvalidRequestException
+     * @expectedExceptionMessage Incorrect amount
+     *
+     * The hash is correct, so the sender knows the shared secret, but the amount
+     * is not what we expected, i.e. what we had requested to be authorized.
+     */
+    public function testCompleteAuthorizeWrongAmount()
+    {
+        $this->getHttpRequest()->request->replace(
+            array(
+                'x_response_code' => '1',
+                'x_trans_id' => '12345',
+                'x_amount' => '20.00',
+                'x_MD5_Hash' => md5('elpmaxe' . 'example' . '12345' . '20.00'),
+            )
+        );
+
+        $response = $this->gateway->completeAuthorize($this->options)->send();
+        //$this->assertTrue($response->isSuccessful());
+        //$this->assertSame('12345', $response->getTransactionReference());
+        //$this->assertNull($response->getMessage());
+    }
+
     public function testPurchase()
     {
         $response = $this->gateway->purchase($this->options)->send();

tests/Message/SIMAuthorizeRequestTest.php

@@ -57,7 +57,7 @@ public function testSend()
 
         $this->assertFalse($response->isSuccessful());
         $this->assertTrue($response->isRedirect());
-        $this->assertNotEmpty($response->getRedirectUrl());
+        $this->assertNotEmpty($response->getRedirectUrl()); // This test is failing; not sure why.
         $this->assertSame('POST', $response->getRedirectMethod());
 
         $redirectData = $response->getRedirectData();