Adding tslint

Author: dios-david

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "apollo-cache-lite",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "A lightweight cache implementation for Apollo Client.",
   "license": "GPL-3.0-or-later",
   "repository": "thedevcore/apollo-cache-lite",
@@ -17,7 +17,9 @@
   "scripts": {
     "test": "jest --runInBand --colors --testPathPattern",
     "test:dev": "jest --runInBand --colors --watch --testPathPattern",
-    "build": "cross-env NODE_ENV=production tsc"
+    "lint": "tslint src/**/*.ts",
+    "build": "cross-env NODE_ENV=production tsc",
+    "prepublish": "npm run lint && npm run test && npm run build"
   },
   "dependencies": {
     "apollo-cache": "1.3.2",
@@ -35,6 +37,7 @@
     "graphql-tools": "4.0.5",
     "jest": "24.9.0",
     "ts-jest": "24.1.0",
+    "tslint": "5.20.0",
     "typescript": "3.6.3"
   }
 }

package.json

@@ -1,9 +1,9 @@
-import { ApolloCache, DataProxy, Cache } from 'apollo-cache';
+import { ApolloCache, Cache, DataProxy, Transaction } from 'apollo-cache';
 import { addTypenameToDocument } from 'apollo-utilities';
-import { DocumentNode } from 'graphql';
 import * as deepmerge from 'deepmerge';
+import { DocumentNode } from 'graphql';
 
-import { CacheStore, SerialisedState, QueryStore} from './cache-interfaces';
+import { CacheStore, QueryStore, SerialisedState } from './cache-interfaces';
 import { getCacheableNodes, getDefaultIdFromNode, getHashForQuery } from './utils';
 
 export interface ApolloCacheLiteOptions {
@@ -28,8 +28,8 @@ export class ApolloCacheLite extends ApolloCache<SerialisedState> {
         const result = this.read(query as Cache.ReadOptions<any>);
 
         return {
-            result,
-            complete: !!result
+            complete: !!result,
+            result
         };
     }
 
@@ -64,7 +64,7 @@ export class ApolloCacheLite extends ApolloCache<SerialisedState> {
             const [type, id] = options.id.split(':');
             return this.store[type][id] as T;
 
-        } catch (o_O) {
+        } catch (e) {
             return;
         }
     }
@@ -88,7 +88,7 @@ export class ApolloCacheLite extends ApolloCache<SerialisedState> {
                 queries: this.queries,
                 store: this.store
             };
-        } catch (o_O) {}
+        } catch (e) {}
 
         return this;
     }
@@ -105,15 +105,18 @@ export class ApolloCacheLite extends ApolloCache<SerialisedState> {
 
     // @TODO
     evict<TVariables = any>(query: Cache.EvictOptions<TVariables>): Cache.EvictionResult {
-        throw new Error("Method not implemented.");
+        throw new Error('[apollo-cache-lite] Method not implemented!');
     }
+
     removeOptimistic(id: string): void {
-        throw new Error("Method not implemented.");
+        throw new Error('[apollo-cache-lite] Method not implemented!');
     }
-    performTransaction(transaction: import("apollo-cache").Transaction<SerialisedState>): void {
-        throw new Error("Method not implemented.");
+
+    performTransaction(transaction: Transaction<SerialisedState>): void {
+        throw new Error('[apollo-cache-lite] Method not implemented!');
     }
-    recordOptimisticTransaction(transaction: import("apollo-cache").Transaction<SerialisedState>, id: string): void {
-        throw new Error("Method not implemented.");
+
+    recordOptimisticTransaction(transaction: Transaction<SerialisedState>, id: string): void {
+        throw new Error('[apollo-cache-lite] Method not implemented!');
     }
 }

src/ApolloCacheLite.ts

@@ -1,3 +1,3 @@
 export * from './ApolloCacheLite';
-export * from './cache-interfaces'
+export * from './cache-interfaces';
 export * from './utils';

src/index.ts

@@ -1,5 +1,5 @@
-import * as deepmerge from 'deepmerge';
 import { Cache } from 'apollo-cache';
+import * as deepmerge from 'deepmerge';
 
 import { CacheStore } from './cache-interfaces';
 
@@ -13,7 +13,9 @@ export function getHash(s: any): string {
 
     for (let i = 0; i < str.length; i++) {
         const char = str.charCodeAt(i);
+        // tslint:disable-next-line:no-bitwise
         hash = ((hash << 5) - hash) + char;
+        // tslint:disable-next-line:no-bitwise
         hash = hash & hash;
     }
 
@@ -27,7 +29,7 @@ export function getHashForQuery(query: Cache.ReadOptions): string {
 export function getCacheableNodes(obj: any, getIdFromNode: (o: any) => string): CacheStore {
     let nodes: CacheStore = {};
 
-    for (const key in obj) {
+    for (const key of Object.keys(obj)) {
         const value = obj[key];
 
         if (key === '__typename') {

src/utils.ts

@@ -0,0 +1,12 @@
+{
+    "extends": "tslint:recommended",
+    "rules": {
+        "arrow-parens": [true, "ban-single-arg-parens"],
+        "forin": false,
+        "interface-name": [true, "never-prefix"],
+        "member-access": [true, "no-public"],
+        "no-empty": [true, "allow-empty-catch"],
+        "quotemark": [true, "single"],
+        "trailing-comma": [true, { "multiline": "never", "singleline": "never"}]
+    }
+}