resolve some warnings, prefer snprinf

Author: jamierpond

test/inc/zoo/debug/rh/RobinHood.debug.h

@@ -1,8 +1,6 @@
 #ifndef ZOO_TEST_ROBINHOOD_DEBUGGING
 #define ZOO_TEST_ROBINHOOD_DEBUGGING
 
-#include "zoo/map/RobinHood.h"
-
 #include <sstream>
 #include <stdio.h>
 
@@ -24,8 +22,9 @@ auto display(
     constexpr auto HexPerHash = (MD::NBitsMost + 3) / 4;
 
     char format[60];
-    snprintf(format, 59, "%%0%dllx %%0%dllx %%0%dllx", HexPerSlot, HexPerSlot, HexPerPSL);
-    
+    const auto hexPerSlot = static_cast<int>(HexPerSlot);
+    snprintf(format, 59, "%%0%dllx %%0%dllx %%0%dllx", hexPerSlot, hexPerSlot, HexPerPSL);
+
     auto swarNdx = begin / MD::NSlots;
     auto swarEnd = end/MD::NSlots;
 
@@ -34,8 +33,9 @@ auto display(
     auto printLine =
         [&]() {
             char buffer[100];
-            sprintf(
+            snprintf(
                 buffer,
+                sizeof(buffer),
                 format,
                 initial.at(0), initial.hashes().at(0), initial.PSLs().at(0)
             );

test/inc/zoo/variant.h

@@ -3,7 +3,6 @@
 #include <tuple>
     // provides std::tuple_element to be able to index a pack of types,
     // indirectly includes type traits and utility
-#include <new>
 #include <zoo/meta/in_place_operations.h>
 #include <zoo/meta/traits.h>
 

test/map/RobinHood.test.cpp

@@ -9,7 +9,6 @@
 #include <algorithm>
 #include <regex>
 #include <map>
-#include <sstream>
 #include <fstream>
 #include <unordered_map>
 
@@ -54,22 +53,23 @@ struct V {
 
 std::ostream &operator<<(std::ostream &out, V v) {
     char buffer[30];
+    const auto bufferSize = sizeof(buffer);
     char *ptr = buffer;
     auto val = v.v;
     auto printHalf = [&](auto low, auto high) {
         for(auto ndx = low; ndx < high; ++ndx) {
             if(v.intraIndex == ndx) {
-                ptr += sprintf(ptr, "<");
+                ptr += snprintf(ptr, bufferSize, "<");
             }
-            ptr += sprintf(ptr, "%02lx", val & 0xFF);
+            ptr += snprintf(ptr, bufferSize, "%02lx", val & 0xFF);
             if(v.intraIndex == ndx) {
-                ptr += sprintf(ptr, ">");
+                ptr += snprintf(ptr, bufferSize, ">");
             }
             val >>= 8;
         }
     };
     printHalf(0, 4);
-    ptr += sprintf(ptr, "'");
+    ptr += snprintf(ptr, bufferSize, "'");
     printHalf(4, 8);
     out << buffer;
     return out;