Merge pull request #11 from thecasualcoder/fix-lint-issues

Fix lint issues

Author: aswinkarthik

common.go

@@ -5,7 +5,6 @@ import (
 	"reflect"
 )
 
-
 func validateOut(output reflect.Value) error {
 	zeroValue := reflect.Value{}
 	if output == zeroValue {

filter.go

@@ -14,7 +14,7 @@ import (
 // Validations:
 //
 //	1. Input and Output's slice should be of same type
-//	2. Predicate function can take one argment and return one argument
+//	2. Predicate function can take one argument and return one argument
 //	3. Predicate's return argument is always boolean.
 //	4. Predicate's input argument should be input/output slice's element type.
 //

filter_test.go

@@ -23,23 +23,22 @@ func TestFilter(t *testing.T) {
 
 	t.Run("should struct types", func(t *testing.T) {
 		type person struct {
-			name string
-			age  int
+			age int
 		}
 		input := []person{
-			{"john", 30},
-			{"doe", 20},
-			{"foo", 40},
-			{"bar", 10},
+			{30},
+			{20},
+			{40},
+			{10},
 		}
 		var output []person
 
 		err := godash.Filter(input, &output, func(p person) bool {
 			return p.age > 20
 		})
 		expected := []person{
-			{"john", 30},
-			{"foo", 40},
+			{30},
+			{40},
 		}
 
 		assert.NoError(t, err)

go.sum

@@ -2,6 +2,7 @@ github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
+github.com/stretchr/objx v0.1.0 h1:4G4v2dO3VZwixGIRoQ5Lfboy6nUhCyYzaqnIAPPhYs4=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.4.0 h1:2E4SXV/wtOkTonXsotYi4li6zVWxYlZuYNCXe9XRJyk=
 github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4=

map_test.go

@@ -24,12 +24,11 @@ func TestMap(t *testing.T) {
 	t.Run("support structs", func(t *testing.T) {
 		type person struct {
 			name string
-			age  int
 		}
 
 		in := []person{
-			{name: "john", age: 20},
-			{name: "doe", age: 23},
+			{name: "john"},
+			{name: "doe"},
 		}
 		out := make([]string, 0)
 		expected := []string{"john", "doe"}

reduce_test.go

@@ -56,13 +56,12 @@ func TestReduce(t *testing.T) {
 
 	t.Run("support structs", func(t *testing.T) {
 		type person struct {
-			name string
-			age  int
+			age int
 		}
 
 		in := []person{
-			{name: "john", age: 20},
-			{name: "doe", age: 23},
+			{age: 20},
+			{age: 23},
 		}
 		out := 0
 		expected := 43