Commit 4a6bf6f
committed
Enable integration_querier and integration_backward_compatibility on ARM64
This commit addresses reviewer feedback to enable these two test suites
on ARM64 architecture while maintaining test reliability.
## Changes
### integration_querier
- Added runtime.GOARCH skip for Thanos engine subtests on non-amd64
- Allows the test suite to run on ARM64, skipping only timing-sensitive
subtests that check exact cache request counts
- These assertions vary across architectures due to performance differences
### integration_backward_compatibility
- Removed support for Cortex v1.13.x-v1.15.x (11 versions)
- Retained only v1.16.0+ (7 versions with ARM64 support)
- Per https://cortexmetrics.io/docs/configuration/v1guarantees/, only
the last 3 minor versions need backward compatibility testing
- All retained versions have ARM64 Docker images available
### Workflow updates
- Added integration_querier and integration_backward_compatibility to ARM64 matrix
- Updated Docker image preloading to match retained versions
- Added v1.19.0 to preload list
## Result
ARM64 test coverage increases from 5/8 to 7/8 integration test suites.
Only integration_query_fuzz remains ARM64-exclusive due to known issue cortexproject#6982.
Addresses: cortexproject#7068 (comment)1 parent aff13a8 commit 4a6bf6f
File tree
3 files changed
+16
-50
lines changed- .github/workflows
- integration
3 files changed
+16
-50
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
200 | 206 | | |
201 | 207 | | |
202 | 208 | | |
| |||
229 | 235 | | |
230 | 236 | | |
231 | 237 | | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | 238 | | |
241 | 239 | | |
242 | 240 | | |
243 | 241 | | |
244 | 242 | | |
245 | 243 | | |
| 244 | + | |
246 | 245 | | |
247 | 246 | | |
248 | 247 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
32 | 34 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | 35 | | |
76 | 36 | | |
77 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
384 | 385 | | |
385 | 386 | | |
386 | 387 | | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
387 | 394 | | |
388 | 395 | | |
389 | 396 | | |
| |||
0 commit comments