Check for new Code reviews wrapped in BgTask

Author: jamo

tmc-plugin/src/fi/helsinki/cs/tmc/actions/CheckForNewReviews.java

@@ -11,6 +11,9 @@
 import fi.helsinki.cs.tmc.model.TmcCoreSingleton;
 import fi.helsinki.cs.tmc.ui.ConvenientDialogDisplayer;
 import fi.helsinki.cs.tmc.core.exceptions.TmcCoreException;
+import fi.helsinki.cs.tmc.utilities.BgTask;
+import fi.helsinki.cs.tmc.utilities.BgTaskListener;
+import fi.helsinki.cs.tmc.utilities.CancellableCallable;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
 import java.util.List;
@@ -79,7 +82,6 @@ public void actionPerformed(ActionEvent e) {
 
     @Override
     public void run() {
-        // TODO(jamo): use bg task
         if (resetNotifications) {
             reviewDb.forgetReviewsNotifiedAbout();
         }
@@ -94,50 +96,40 @@ public void run() {
         if (course.getReviewsUrl() == null) {
             return;
         }
-        getReviews(course);
-
-    }
-    
-    private void getReviews(Course course){
-        final ProgressHandle progress = ProgressHandleFactory.createHandle("Checking for code reviews");
-        progress.start();
-        try {
-            ListenableFuture<List<Review>> reviews = TmcCoreSingleton.getInstance()
-                    .getNewReviews(course);
-            Futures.addCallback(reviews, new FutureCallback<List<Review>>() {
-
-                @Override
-                public void onSuccess(List<Review> v) {
-                    success(v);
-                    progress.finish();
-                    
+        BgTaskListener bgTaskListener = new BgTaskListener<List<Review>>() {
+            @Override
+            public void bgTaskReady(List<Review> result) {
+                boolean newReviews = reviewDb.setReviews(result);
+                if (!newReviews && notifyAboutNoNewReviews) {
+                    dialogs.displayMessage("You have no unread code reviews.");
                 }
+            }
 
-                @Override
-                public void onFailure(Throwable thrwbl) {
-                    fail(thrwbl);
-                    progress.finish();
+            @Override
+            public void bgTaskFailed(final Throwable ex) {
+                final String msg = "Failed to check for code reviews";
+                log.log(Level.INFO, msg, ex);
+                if (!beQuiet) {
+                    dialogs.displayError(msg, ex);
                 }
+            }
 
-            });
-        } catch (TmcCoreException ex) {
-            progress.finish();
-            Exceptions.printStackTrace(ex);
-        }
-    }
-
-    private void success(List<Review> list) {
-        boolean newReviews = reviewDb.setReviews(list);
-        if (!newReviews && notifyAboutNoNewReviews) {
-            dialogs.displayMessage("You have no unread code reviews.");
-        }
-    }
+            @Override
+            public void bgTaskCancelled() {
+            }
+        };
+        BgTask.start("Checking for code reviews", new CancellableCallable<List<Review>>() {
+            private ListenableFuture<List<Review>> lf;
+            @Override
+            public List<Review> call() throws Exception {
+                lf = TmcCoreSingleton.getInstance().getNewReviews(courseDb.getCurrentCourse());
+                return lf.get();
+            }
 
-    private void fail(Throwable thrwbl) {
-        final String msg = "Failed to check for code reviews";
-        log.log(Level.INFO, msg, thrwbl);
-        if (!beQuiet) {
-            dialogs.displayError(msg, thrwbl);
-        }
+            @Override
+            public boolean cancel() {
+                return lf.cancel(true);
+            }
+        }, bgTaskListener);
     }
 }