Skip to content

Commit 6db224c

Browse files
chore(deps-dev): Bump kcd-scripts from 11.2.2 to 12.2.0 (#343)
* chore(deps-dev): Bump kcd-scripts from 11.2.2 to 12.2.0 Bumps [kcd-scripts](https://github.com/kentcdodds/kcd-scripts) from 11.2.2 to 12.2.0. - [Release notes](https://github.com/kentcdodds/kcd-scripts/releases) - [Changelog](https://github.com/kentcdodds/kcd-scripts/blob/main/CHANGELOG.md) - [Commits](kentcdodds/kcd-scripts@v11.2.2...v12.2.0) --- updated-dependencies: - dependency-name: kcd-scripts dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * chore: drop support for Node 10 * chore: disables eslint rule new-cap * test: minor lint fix BREAKING CHANGE: drops support for Node 10 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christian Hagendorn <200940+Hagendorn@users.noreply.github.com>
1 parent ef750b2 commit 6db224c

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

.github/workflows/testcafe-testing-library.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
matrix:
1515
os: [ubuntu-latest]
16-
node: [10, 12, 14, 16]
16+
node: [12, 14, 16]
1717
browser: ["chrome:headless", "firefox:headless"]
1818
steps:
1919
- uses: actions/setup-node@v3

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"eslint": "^7.6.0",
3232
"eslint-config-prettier": "^8.1.0",
3333
"eslint-plugin-testcafe": "^0.2.1",
34-
"kcd-scripts": "^11.2.0",
34+
"kcd-scripts": "^12.2.0",
3535
"npm-run-all": "^4.1.5",
3636
"prettier": "^2.3.2",
3737
"semantic-release": "^17.0.7",
@@ -44,7 +44,7 @@
4444
"url": "https://github.com/testing-library/testcafe-testing-library.git"
4545
},
4646
"engines": {
47-
"node": ">=10",
47+
"node": ">=12",
4848
"npm": ">=6"
4949
}
5050
}

src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/* eslint-disable @typescript-eslint/no-implied-eval */
22
/* eslint-disable no-new-func */
3+
/* eslint-disable new-cap */
34
import { ClientFunction, Selector } from "testcafe";
45
import { Matcher, queries } from "@testing-library/dom";
56
import type { Options, QueryName, WithinSelectors } from "./types";

tests/testcafe/within.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/* eslint-disable testing-library/prefer-screen-queries */
22
/* eslint-disable @typescript-eslint/await-thenable */
3+
/* eslint-disable new-cap */
34
import { Selector } from "testcafe";
45
import { within, screen } from "../../src";
56

@@ -68,7 +69,7 @@ test('works with nested selector from "All" query with index - exact:false', asy
6869
test('works with nested selector from "All" query with index - function', async (t) => {
6970
const nestedDivs = screen.getAllByTestId((_content, element) =>
7071
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
71-
element.getAttribute("data-testid")!.startsWith("nested")
72+
element!.getAttribute("data-testid")!.startsWith("nested")
7273
);
7374
await t.expect(nestedDivs.count).eql(2);
7475
const nested = await within(nestedDivs.nth(0));

0 commit comments

Comments
 (0)