Skip to content

Commit 6a537f5

Browse files
authored
Merge pull request #164 from gillchristian/pr/update-docs
support(docs): Update update docs
2 parents ff29456 + c74edcf commit 6a537f5

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

.all-contributorsrc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,15 @@
129129
"contributions": [
130130
"blog"
131131
]
132+
},
133+
{
134+
"login": "gillchristian",
135+
"name": "Christian Gill",
136+
"avatar_url": "https://avatars2.githubusercontent.com/u/8309423?v=4",
137+
"profile": "https://gillchristian.xyz",
138+
"contributions": [
139+
"doc"
140+
]
132141
}
133142
],
134143
"commitConvention": "none"

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
[![downloads](https://img.shields.io/npm/dm/@testing-library/react-hooks.svg?style=flat-square)](http://www.npmtrends.com/@testing-library/react-hooks)
2828
[![MIT License](https://img.shields.io/npm/l/@testing-library/react-hooks.svg?style=flat-square)](https://github.com/testing-library/react-hooks-testing-library/blob/master/LICENSE.md)
2929

30-
[![All Contributors](https://img.shields.io/badge/all_contributors-12-orange.svg?style=flat-square)](#contributors-)
30+
[![All Contributors](https://img.shields.io/badge/all_contributors-13-orange.svg?style=flat-square)](#contributors-)
3131
[![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat-square)](http://makeapullrequest.com)
3232
[![Code of Conduct](https://img.shields.io/badge/code%20of-conduct-ff69b4.svg?style=flat-square)](https://github.com/testing-library/react-hooks-testing-library/blob/master/CODE_OF_CONDUCT.md)
3333
[![Netlify Status](https://api.netlify.com/api/v1/badges/9a8f27a5-df38-4910-a248-4908b1ba29a7/deploy-status)](https://app.netlify.com/sites/react-hooks-testing-library/deploys)
@@ -155,7 +155,8 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
155155
<td align="center"><a href="https://github.com/mtinner"><img src="https://avatars0.githubusercontent.com/u/5487448?v=4" width="100px;" alt="Marcel Tinner"/><br /><sub><b>Marcel Tinner</b></sub></a><br /><a href="https://github.com/testing-library/react-hooks-testing-library/commits?author=mtinner" title="Documentation">📖</a></td>
156156
<td align="center"><a href="https://github.com/FredyC"><img src="https://avatars0.githubusercontent.com/u/1096340?v=4" width="100px;" alt="Daniel K."/><br /><sub><b>Daniel K.</b></sub></a><br /><a href="https://github.com/testing-library/react-hooks-testing-library/issues?q=author%3AFredyC" title="Bug reports">🐛</a> <a href="https://github.com/testing-library/react-hooks-testing-library/commits?author=FredyC" title="Code">💻</a></td>
157157
<td align="center"><a href="https://github.com/VinceMalone"><img src="https://avatars0.githubusercontent.com/u/2516349?v=4" width="100px;" alt="Vince Malone"/><br /><sub><b>Vince Malone</b></sub></a><br /><a href="https://github.com/testing-library/react-hooks-testing-library/commits?author=VinceMalone" title="Code">💻</a></td>
158-
<td align="center"><a href="https://github.com/doppelmutzi"><img src="https://avatars1.githubusercontent.com/u/4130968?v=4" width="100px;" alt="doppelmutzi"/><br /><sub><b>doppelmutzi</b></sub></a><br /><a href="#blog-doppelmutzi" title="Blogposts">📝</a></td>
158+
<td align="center"><a href="https://github.com/doppelmutzi"><img src="https://avatars1.githubusercontent.com/u/4130968?v=4" width="100px;" alt="Sebastian Weber"/><br /><sub><b>Sebastian Weber</b></sub></a><br /><a href="#blog-doppelmutzi" title="Blogposts">📝</a></td>
159+
<td align="center"><a href="https://gillchristian.xyz"><img src="https://avatars2.githubusercontent.com/u/8309423?v=4" width="100px;" alt="Christian Gill"/><br /><sub><b>Christian Gill</b></sub></a><br /><a href="https://github.com/testing-library/react-hooks-testing-library/commits?author=gillchristian" title="Documentation">📖</a></td>
159160
</tr>
160161
</table>
161162

docs/usage/basic-hooks.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,10 @@ You may have also noticed that we also wrapped the `increment` call in `act`. Th
6565
how our hook will act in a browser, allowing us to update the values within it. For more details on
6666
`act`, please see the [React documentation](https://fb.me/react-wrap-tests-with-act).
6767

68+
**NOTE**: There's a gottcha with updates. `renderHook` mutates the value of `current` when updates
69+
happen so you cannot destructure its values as the assignment will make a copy locking into the
70+
value at that time.
71+
6872
## Providing Props
6973

7074
Sometimes a hook relies on the props passed to it in order to do it's thing. For example the

0 commit comments

Comments
 (0)