🚚 Move tests back / ⬆️ Upgrade @hover/javascript (#88)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: 3 people

.eslintignore

@@ -0,0 +1,5 @@
+node_modules/
+coverage/
+dist/
+extend.js
+extend.d.ts

.eslintrc.js

@@ -1,9 +1,10 @@
-const { overrides, ...config } = require('@hover/javascript/eslint')
+const {overrides, ...config} = require('@hover/javascript/eslint')
 
 module.exports = {
   ...config,
   ignorePatterns: ['dom-testing-library.js', 'rollup.input.js'],
   parserOptions: {
-    project: ['tsconfig.json', 'tsconfig.eslint.json'],
+    tsconfigRootDir: __dirname,
+    project: ['tsconfig.eslint.json', 'tsconfig.json'],
   },
 }

package.json

@@ -48,7 +48,7 @@
     "wait-for-expect": "^3.0.2"
   },
   "devDependencies": {
-    "@hover/javascript": "^4.4.0",
+    "@hover/javascript": "^4.17.0",
     "@rollup/plugin-commonjs": "^15.0.0",
     "@rollup/plugin-node-resolve": "^8.0.0",
     "@rollup/plugin-replace": "^2.3.1",

lib/__tests__/__snapshots__/extend.ts.snap renamed to test/__snapshots__/extend.test.ts.snap

@@ -6,18 +6,18 @@ describe('lib/extend.ts', () => {
   let page: playwright.Page
   let document: playwright.ElementHandle
 
-  it('should require without error', async () => {
-    await import('../extend')
-  })
+  beforeAll(async () => {
+    await import('../lib/extend')
 
-  it('should launch playwright', async () => {
     browser = await playwright.chromium.launch({args: ['--no-sandbox', '--disable-setuid-sandbox']})
     page = await browser.newPage()
+
     await page.goto(`file://${path.join(__dirname, 'fixtures/page.html')}`)
+
+    document = await page.getDocument()
   })
 
   it('should extend playwright ElementHandle', async () => {
-    document = await page.getDocument()
     expect(typeof document.queryAllByAltText).toBe('function')
   })
 
@@ -57,6 +57,7 @@ describe('lib/extend.ts', () => {
       fail() // eslint-disable-line jest/no-jasmine-globals
     } catch (err) {
       err.message = err.message.replace(/(\s*at .*(\n|$))+/gm, '\n    <stack>:X:X')
+      // eslint-disable-next-line jest/no-try-expect
       expect(err.message).toMatchSnapshot()
     }
   })

lib/__tests__/extend.ts renamed to test/extend.test.ts

@@ -1,12 +1,12 @@
 import * as path from 'path'
 import * as playwright from 'playwright'
-import {getDocument, queries, getQueriesForElement, waitFor, configure} from '..'
+import {getDocument, queries, getQueriesForElement, waitFor, configure} from '../lib'
 
 describe('lib/index.ts', () => {
   let browser: playwright.Browser
   let page: playwright.Page
 
-  it('should launch playwright', async () => {
+  beforeAll(async () => {
     browser = await playwright.chromium.launch({args: ['--no-sandbox', '--disable-setuid-sandbox']})
     page = await browser.newPage()
     await page.goto(`file://${path.join(__dirname, 'fixtures/page.html')}`)
@@ -55,16 +55,16 @@ describe('lib/index.ts', () => {
     expect(await queries.getNodeText(element)).toEqual('Hello h1')
   })
 
-  it('should load the defered page', async () => {
-    await page.goto(`file://${path.join(__dirname, 'fixtures/late-page.html')}`)
-  })
+  describe('loading the deferred page', () => {
+    beforeEach(async () => page.goto(`file://${path.join(__dirname, 'fixtures/late-page.html')}`))
 
-  it('should use `wait` properly', async () => {
-    const {getByText} = getQueriesForElement(await getDocument(page))
-    // eslint-disable-next-line @typescript-eslint/no-misused-promises
-    await waitFor(() => getByText('Loaded!'), {timeout: 7000})
-    expect(await getByText('Loaded!')).toBeTruthy()
-  }, 9000)
+    it('should use `wait` properly', async () => {
+      const {getByText} = getQueriesForElement(await getDocument(page))
+      // eslint-disable-next-line @typescript-eslint/no-misused-promises
+      await waitFor(() => getByText('Loaded!'), {timeout: 7000})
+      expect(await getByText('Loaded!')).toBeTruthy()
+    }, 9000)
+  })
 
   afterEach(() => {
     configure({testIdAttribute: 'data-testid'}) // cleanup

lib/__tests__/fixtures/late-page.html renamed to test/fixtures/late-page.html

@@ -3,6 +3,5 @@
   "compilerOptions": {
     "allowJs": true
   },
-  "include": ["lib/**/__tests__/**/*", "**/*.config.js"],
-  "exclude": []
+  "include": ["test", "**/*.config.js"]
 }

lib/__tests__/fixtures/page.html renamed to test/fixtures/page.html

@@ -16,6 +16,5 @@
     "strictNullChecks": true,
     "preserveWatchOutput": true
   },
-  "include": ["lib"],
-  "exclude": ["**/__tests__/**/*"]
+  "include": ["lib"]
 }