chore(deps): update typescript to v3 (#27)

Author: abraham

lib/extend.ts

@@ -1,5 +1,6 @@
-import {getDocument, getQueriesForElement} from '.'
 import {ElementHandle} from '../node_modules/@types/puppeteer'
+
+import {getDocument, getQueriesForElement} from '.'
 import {IScopedQueryUtils} from './typedefs'
 
 // tslint:disable-next-line

lib/index.ts

@@ -2,6 +2,7 @@ import {readFileSync} from 'fs'
 import * as path from 'path'
 import {ElementHandle, EvaluateFn, JSHandle, Page} from 'puppeteer'
 import waitForExpect from 'wait-for-expect'
+
 import {IQueryUtils, IScopedQueryUtils} from './typedefs'
 
 const domLibraryAsString = readFileSync(
@@ -32,7 +33,7 @@ type ContextFn = (...args: any[]) => ElementHandle
 
 async function createElementHandleArray(handle: JSHandle): Promise<ElementHandle[]> {
   const lengthHandle = await handle.getProperty('length')
-  const length = await lengthHandle.jsonValue()
+  const length = await lengthHandle.jsonValue() as number
 
   const elements: ElementHandle[] = []
   for (let i = 0; i < length; i++) {

package.json

@@ -34,7 +34,20 @@
   "config": {
     "tslint": {
       "rules": {
-        "no-unsafe-any": false
+        "increment-decrement": false,
+        "no-unsafe-any": false,
+        "ban-ts-ignore": {
+          "severity": "warning"
+        },
+        "function-constructor": {
+          "severity": "warning"
+        },
+        "strict-comparisons": {
+          "severity": "warning"
+        },
+        "match-default-export-name": {
+          "severity": "warning"
+        }
       }
     },
     "exportAliases": {
@@ -56,9 +69,9 @@
     "rollup-plugin-commonjs": "^10.1.0",
     "rollup-plugin-node-resolve": "^5.2.0",
     "rollup-plugin-replace": "^2.2.0",
-    "ts-jest": "^22.4.6",
-    "tslint": "^5.10.0",
-    "typescript": "^2.9.2"
+    "ts-jest": "^25.2.1",
+    "tslint": "^6.0.0",
+    "typescript": "^3.8.3"
   },
   "peerDependencies": {
     "puppeteer": "^1.5.0 || ^2.0.0"

test/extend.test.ts

@@ -53,7 +53,7 @@ describe('lib/extend.ts', () => {
     const scope = await document.$('#scoped')
 
     try {
-      await scope.getByTitle('missing')
+      await scope!.getByTitle('missing')
       fail()
     } catch (err) {
       err.message = err.message.replace(/(\s*at .*(\n|$))+/gm, '\n    <stack>:X:X')
@@ -82,18 +82,18 @@ describe('lib/extend.ts', () => {
 
   it('should scope results to element', async () => {
     const scope = await document.$('#scoped')
-    const element = await scope.queryByText(/Hello/)
+    const element = await scope!.queryByText(/Hello/)
     /* istanbul ignore next */
     expect(await page.evaluate(el => el.textContent, element)).toEqual('Hello h3')
   })
 
   it('should get text content', async () => {
     const $h3 = await document.$('#scoped h3')
-    expect(await $h3.getNodeText()).toEqual('Hello h3')
+    expect(await $h3!.getNodeText()).toEqual('Hello h3')
   })
 
   it('should work with destructuring', async () => {
-    const {queryByText} = (await document.$('#scoped')).getQueriesForElement()
+    const {queryByText} = (await document.$('#scoped'))!.getQueriesForElement()
     expect(await queryByText('Hello h1')).toBeFalsy()
     expect(await queryByText('Hello h3')).toBeTruthy()
   })