test: reach 100% code coverage (#35)

Author: Thomas Lombart

lib/rules/await-async-query.js

@@ -36,19 +36,16 @@ module.exports = {
       },
       'Program:exit'() {
         testingLibraryQueryUsage.forEach(node => {
-          const variableDeclaratorParent = findParent(
-            node,
-            parent => parent.type === 'VariableDeclarator'
-          );
+          const variableDeclaratorParent = node.parent.parent;
 
           const references =
-            (variableDeclaratorParent &&
-              context
-                .getDeclaredVariables(variableDeclaratorParent)[0]
-                .references.slice(1)) ||
-            [];
+            variableDeclaratorParent.type === 'VariableDeclarator' &&
+            context
+              .getDeclaredVariables(variableDeclaratorParent)[0]
+              .references.slice(1);
 
           if (
+            references &&
             references.length === 0 &&
             !isAwaited(node.parent.parent) &&
             !isPromiseResolved(node)
@@ -103,12 +100,3 @@ function isPromiseResolved(node) {
   // promise.then(...)
   return hasAThenProperty(parent);
 }
-
-function findParent(node, check) {
-  if (check(node)) {
-    return node;
-  } else if (node.parent) {
-    return findParent(node.parent, check);
-  }
-  return null;
-}

lib/rules/await-fire-event.js

@@ -14,9 +14,7 @@ function isPromiseResolved(node) {
   const parent = node.parent.parent;
 
   // fireEvent.click().then(...)
-  if (parent.type === 'CallExpression') {
-    return hasThenProperty(parent.parent);
-  }
+  return parent.type === 'CallExpression' && hasThenProperty(parent.parent);
 }
 
 const VALID_PARENTS = [

tests/lib/rules/prefer-expect-query-by.js

@@ -25,6 +25,7 @@ ruleTester.run('prefer-expect-query-by', rule, {
     (validRules, queryName) => [
       ...validRules,
       { code: `expect(${queryName}('Hello')).toBeInTheDocument()` },
+      { code: `expect(${queryName}).toBeInTheDocument()` },
       { code: `expect(rendered.${queryName}('Hello')).toBeInTheDocument()` },
       { code: `expect(${queryName}('Hello')).not.toBeInTheDocument()` },
       {