refactor: rename helpers for determining query variants

Author: Belco90

lib/detect-testing-library-utils.ts

@@ -52,9 +52,9 @@ export type DetectionHelpers = {
   getCustomModuleImportName: () => string | undefined;
   isTestingLibraryImported: () => boolean;
   isValidFilename: () => boolean;
-  isGetByQuery: (node: TSESTree.Identifier) => boolean;
-  isQueryByQuery: (node: TSESTree.Identifier) => boolean;
-  isFindByQuery: (node: TSESTree.Identifier) => boolean;
+  isGetQueryVariant: (node: TSESTree.Identifier) => boolean;
+  isQueryQueryVariant: (node: TSESTree.Identifier) => boolean;
+  isFindQueryVariant: (node: TSESTree.Identifier) => boolean;
   isSyncQuery: (node: TSESTree.Identifier) => boolean;
   isAsyncQuery: (node: TSESTree.Identifier) => boolean;
   isCustomQuery: (node: TSESTree.Identifier) => boolean;
@@ -152,38 +152,42 @@ export function detectTestingLibraryUtils<
     };
 
     /**
-     * Determines whether a given node is `getBy*` or `getAllBy*` query variant or not.
+     * Determines whether a given node is `get*` query variant or not.
      */
-    const isGetByQuery: DetectionHelpers['isGetByQuery'] = (node) => {
+    const isGetQueryVariant: DetectionHelpers['isGetQueryVariant'] = (node) => {
       return /^get(All)?By.+$/.test(node.name);
     };
 
     /**
-     * Determines whether a given node is `queryBy*` or `queryAllBy*` query variant or not.
+     * Determines whether a given node is `query*` query variant or not.
      */
-    const isQueryByQuery: DetectionHelpers['isQueryByQuery'] = (node) => {
+    const isQueryQueryVariant: DetectionHelpers['isQueryQueryVariant'] = (
+      node
+    ) => {
       return /^query(All)?By.+$/.test(node.name);
     };
 
     /**
-     * Determines whether a given node is `findBy*` or `findAllBy*` query variant or not.
+     * Determines whether a given node is `find*` query variant or not.
      */
-    const isFindByQuery: DetectionHelpers['isFindByQuery'] = (node) => {
+    const isFindQueryVariant: DetectionHelpers['isFindQueryVariant'] = (
+      node
+    ) => {
       return /^find(All)?By.+$/.test(node.name);
     };
 
     /**
      * Determines whether a given node is sync query or not.
      */
     const isSyncQuery: DetectionHelpers['isSyncQuery'] = (node) => {
-      return isGetByQuery(node) || isQueryByQuery(node);
+      return isGetQueryVariant(node) || isQueryQueryVariant(node);
     };
 
     /**
      * Determines whether a given node is async query or not.
      */
     const isAsyncQuery: DetectionHelpers['isAsyncQuery'] = (node) => {
-      return isFindByQuery(node);
+      return isFindQueryVariant(node);
     };
 
     const isCustomQuery: DetectionHelpers['isCustomQuery'] = (node) => {
@@ -364,9 +368,9 @@ export function detectTestingLibraryUtils<
       getCustomModuleImportName,
       isTestingLibraryImported,
       isValidFilename,
-      isGetByQuery,
-      isQueryByQuery,
-      isFindByQuery,
+      isGetQueryVariant,
+      isQueryQueryVariant,
+      isFindQueryVariant,
       isSyncQuery,
       isAsyncQuery,
       isCustomQuery,

lib/rules/prefer-explicit-assert.ts

@@ -54,7 +54,7 @@ export default createTestingLibraryRule<Options, MessageIds>({
 
     return {
       'CallExpression Identifier'(node: TSESTree.Identifier) {
-        if (helpers.isGetByQuery(node)) {
+        if (helpers.isGetQueryVariant(node)) {
           getQueryCalls.push(node);
         }
       },

lib/rules/prefer-presence-queries.ts

@@ -42,7 +42,7 @@ export default createTestingLibraryRule<Options, MessageIds>({
           return;
         }
 
-        const isPresenceQuery = helpers.isGetByQuery(node);
+        const isPresenceQuery = helpers.isGetQueryVariant(node);
         const expectStatement = expectCallNode.parent;
         const isPresenceAssert = helpers.isPresenceAssert(expectStatement);
         const isAbsenceAssert = helpers.isAbsenceAssert(expectStatement);

tests/fake-rule.ts

@@ -50,15 +50,15 @@ export default createTestingLibraryRule<Options, MessageIds>({
       }
 
       // force queries to be reported
-      if (helpers.isGetByQuery(node)) {
+      if (helpers.isGetQueryVariant(node)) {
         return context.report({ node, messageId: 'getByError' });
       }
 
-      if (helpers.isQueryByQuery(node)) {
+      if (helpers.isQueryQueryVariant(node)) {
         return context.report({ node, messageId: 'queryByError' });
       }
 
-      if (helpers.isFindByQuery(node)) {
+      if (helpers.isFindQueryVariant(node)) {
         return context.report({ node, messageId: 'findByError' });
       }
     };