fix: fixed bug w/ toHaveAttribute("aria-check", "true") (#50)

Author: benmonro

package.json

@@ -41,7 +41,10 @@
     "eslint": "^7.0.0"
   },
   "eslintConfig": {
-    "extends": "./node_modules/kcd-scripts/eslint.js"
+    "extends": "./node_modules/kcd-scripts/eslint.js",
+    "rules": {
+      "babel/quotes": "off"
+    }
   },
   "eslintIgnore": [
     "node_modules",

src/__tests__/__fixtures__/createBannedAttributeTestCases.js

@@ -137,6 +137,24 @@ export default ({ preferred, negatedPreferred, attribute }) => {
         ],
         output: `expect(element).${preferred}`,
       },
+      {
+        code: `expect(getByText("foo")).toHaveAttribute("${attribute}", "true")`,
+        errors: [
+          {
+            message: `Use ${preferred} instead of toHaveAttribute("${attribute}", "true")`,
+          },
+        ],
+        output: `expect(getByText("foo")).${preferred}`,
+      },
+      {
+        code: `expect(getByText("foo")).toHaveAttribute("${attribute}", "false")`,
+        errors: [
+          {
+            message: `Use ${negatedPreferred} instead of toHaveAttribute("${attribute}", "false")`,
+          },
+        ],
+        output: `expect(getByText("foo")).${negatedPreferred}`,
+      },
       {
         code: `expect(getByText("foo")).toHaveAttribute("${attribute}", "")`,
         errors: [

src/createBannedAttributeRule.js

@@ -2,6 +2,8 @@ export default ({ preferred, negatedPreferred, attributes }) => (context) => {
   const getCorrectFunctionFor = (node, negated = false) =>
     (node.arguments.length === 1 ||
       node.arguments[1].value === true ||
+      (typeof node.arguments[1].value === "string" &&
+        node.arguments[1].value.toLowerCase() === "true") ||
       node.arguments[1].value === "") &&
     !negated
       ? preferred