fix(prefer-empty): Improve fixer for prefer-empty (#73)

Author: benmonro

src/__tests__/lib/rules/prefer-empty.js

@@ -20,12 +20,26 @@ ruleTester.run("prefer-empty", rule, {
   valid: [
     `expect(element.innerHTML).toBe('foo')`,
     `expect(element.innerHTML).toBe(foo)`,
+    `expect(element.innerHTML).toBe(foo + bar)`,
+    `expect(element.innerHTML).toBe(foo())`,
+    `expect(element.innerHTML).toBe(foo().bar)`,
+    `expect(element.innerHTML).toBe(foo.bar)`,
+    `expect(element.innerHTML).not.toBe(foo + bar)`,
+    `expect(element.innerHTML).not.toBe(foo())`,
+    `expect(element.innerHTML).not.toBe(foo().bar)`,
+    `expect(element.innerHTML).not.toBe(foo.bar)`,
     `expect(element.innerHTML).not.toBe('foo')`,
     `expect(element.innerHTML).not.toBe(foo)`,
     "expect(statusText.innerHTML).toBe(`${value}%`)",
     "expect(statusText.innerHTML).not.toBe(`${value}%`)",
+    "expect(statusText.innerHTML).toBe(`value`)",
+    "expect(statusText.innerHTML).not.toBe(`value`)",
+    "expect(statusText.innerHTML).toBe(` `)",
+    "expect(statusText.innerHTML).not.toBe(` `)",
     `expect(element.firstChild).toBe('foo')`,
     `expect(element.firstChild).not.toBe('foo')`,
+    "expect(element.firstChild).toBe(`foo`)",
+    'expect(screen.getByText("foo").innerHTML).toBe(`foo ${bar}`)',
     `expect(getByText("foo").innerHTML).toBe('foo')`,
     `expect(getByText("foo").innerHTML).not.toBe('foo')`,
     `expect(getByText("foo").firstChild).toBe('foo')`,

src/rules/prefer-empty.js

@@ -56,11 +56,7 @@ export const create = (context) => ({
     node
   ) {
     const args = node.parent.parent.parent.arguments[0];
-    if (
-      args.value ||
-      args.name ||
-      (args.expressions && args.expressions.length)
-    ) {
+    if (isNonEmptyStringOrTemplateLiteral(args)) {
       return;
     }
 
@@ -74,15 +70,12 @@ export const create = (context) => ({
       ],
     });
   },
+
   [`MemberExpression[property.name='innerHTML'][parent.parent.property.name='not'][parent.parent.parent.property.name=/toBe$|to(Strict)?Equal$/][parent.parent.object.callee.name='expect']`](
     node
   ) {
     const args = node.parent.parent.parent.parent.arguments[0];
-    if (
-      args.value ||
-      args.name ||
-      (args.expressions && args.expressions.length)
-    ) {
+    if (isNonEmptyStringOrTemplateLiteral(args)) {
       return;
     }
 
@@ -164,3 +157,13 @@ export const create = (context) => ({
     });
   },
 });
+
+function isNonEmptyStringOrTemplateLiteral(node) {
+  return (
+    !(node.type === "Literal" || node.type === "TemplateLiteral") ||
+    node.value ||
+    node.name ||
+    (node?.quasis?.length > 0 &&
+      !(node?.quasis?.length === 1 && node?.quasis[0]?.value?.raw === ""))
+  );
+}