fix: don't report expect(el.innerHTML).toBe(foo) (#63)

Author: benmonro

docs/rules/prefer-empty.md

@@ -8,11 +8,13 @@ readability.
 
 This autofixable rule aims to ensure usage of `.toBeEmptyDOMElement()`
 
-Examples of **incorrect** code for this rule:
+Examples of **correct** code for this rule:
 
 ```js
 expect(element.innerHTML).toBe("foo");
+expect(element.innerHTML).toBe(foo);
 expect(element.innerHTML).not.toBe("foo");
+expect(element.innerHTML).not.toBe(foo);
 expect(element.firstChild).toBe("foo");
 expect(element.firstChild).not.toBe("foo");
 expect(getByText("foo").innerHTML).toBe("foo");
@@ -28,7 +30,7 @@ expect(element.firstChild !== null).toBe(false);
 expect(element.firstChild === null).toBe(false);
 ```
 
-Examples of **correct** code for this rule:
+Examples of **incorrect** code for this rule:
 
 ```js
 expect(element.innerHTML).toBe("");

src/__tests__/lib/rules/prefer-empty.js

@@ -18,7 +18,9 @@ const ruleTester = new RuleTester();
 ruleTester.run("prefer-empty", rule, {
   valid: [
     `expect(element.innerHTML).toBe('foo')`,
+    `expect(element.innerHTML).toBe(foo)`,
     `expect(element.innerHTML).not.toBe('foo')`,
+    `expect(element.innerHTML).not.toBe(foo)`,
     `expect(element.firstChild).toBe('foo')`,
     `expect(element.firstChild).not.toBe('foo')`,
     `expect(getByText("foo").innerHTML).toBe('foo')`,

src/rules/prefer-empty.js

@@ -55,7 +55,8 @@ export const create = (context) => ({
   [`MemberExpression[property.name = 'innerHTML'][parent.callee.name = 'expect'][parent.parent.property.name = /toBe$|to(Strict)?Equal/]`](
     node
   ) {
-    if (node.parent.parent.parent.arguments[0].value) {
+    const args = node.parent.parent.parent.arguments[0];
+    if (args.value || args.name) {
       return;
     }
 
@@ -72,7 +73,8 @@ export const create = (context) => ({
   [`MemberExpression[property.name='innerHTML'][parent.parent.property.name='not'][parent.parent.parent.property.name=/toBe$|to(Strict)?Equal$/][parent.parent.object.callee.name='expect']`](
     node
   ) {
-    if (node.parent.parent.parent.parent.arguments[0].value) {
+    const args = node.parent.parent.parent.parent.arguments[0];
+    if (args.value || args.name) {
       return;
     }