fix(to-have-attribute): fixed bug in prefer-to-have-attribute autofix (#64)

Author: benmonro

src/__tests__/lib/rules/prefer-to-have-attribute.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-template-curly-in-string */
 /**
  * @fileoverview prefer toHaveAttribute over checking  getAttribute/hasAttribute
  * @author Ben Monro
@@ -14,7 +15,7 @@ import * as rule from "../../../rules/prefer-to-have-attribute";
 // Tests
 //------------------------------------------------------------------------------
 
-const ruleTester = new RuleTester();
+const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2015 } });
 ruleTester.run("prefer-to-have-attribute", rule, {
   valid: [
     "expect(element.foo).toBeTruthy()",
@@ -42,6 +43,17 @@ ruleTester.run("prefer-to-have-attribute", rule, {
       ],
       output: `expect(element).toHaveAttribute('foo', expect.stringContaining('bar'));`,
     },
+    {
+      code:
+        "expect(element.getAttribute('foo')).toContain(`bar=${encodeURIComponent(baz.id)}`);",
+      errors: [
+        {
+          message: "Use toHaveAttribute instead of asserting on getAttribute",
+        },
+      ],
+      output:
+        "expect(element).toHaveAttribute('foo', expect.stringContaining(`bar=${encodeURIComponent(baz.id)}`));",
+    },
     {
       code: 'expect(element.getAttribute("foo")).toBe("bar")',
       errors: [

src/rules/prefer-to-have-attribute.js

@@ -30,14 +30,17 @@ export const create = (context) => ({
             node.parent.parent.property.range[0],
             node.parent.parent.parent.range[1],
           ],
-          `not.toHaveAttribute(${node.arguments[0].raw})`
+          `not.toHaveAttribute(${context
+            .getSourceCode()
+            .getText(node.arguments[0])})`
         ),
       ],
     });
   },
   [`CallExpression[callee.property.name='getAttribute'][parent.callee.name='expect'][parent.parent.property.name=/toContain$|toMatch$/]`](
     node
   ) {
+    const sourceCode = context.getSourceCode();
     context.report({
       node: node.parent,
       message: `Use toHaveAttribute instead of asserting on getAttribute`,
@@ -46,11 +49,11 @@ export const create = (context) => ({
         fixer.replaceText(node.parent.parent.property, "toHaveAttribute"),
         fixer.replaceText(
           node.parent.parent.parent.arguments[0],
-          `${
-            node.arguments[0].raw
-          }, expect.string${node.parent.parent.property.name.slice(2)}ing(${
-            node.parent.parent.parent.arguments[0].raw
-          })`
+          `${sourceCode.getText(
+            node.arguments[0]
+          )}, expect.string${node.parent.parent.property.name.slice(
+            2
+          )}ing(${sourceCode.getText(node.parent.parent.parent.arguments[0])})`
         ),
       ],
     });
@@ -62,18 +65,19 @@ export const create = (context) => ({
     const isNullOrEmpty =
       arg.length > 0 && (arg[0].value === null || arg[0].value === "");
 
+    const sourceCode = context.getSourceCode();
     context.report({
       node: node.parent,
       message: `Use toHaveAttribute instead of asserting on getAttribute`,
       fix: (fixer) => {
         const lastFixer = isNullOrEmpty
           ? fixer.replaceText(
               node.parent.parent.parent.arguments[0],
-              node.arguments[0].raw
+              sourceCode.getText(node.arguments[0])
             )
           : fixer.insertTextBefore(
               node.parent.parent.parent.arguments[0],
-              `${node.arguments[0].raw}, `
+              `${sourceCode.getText(node.arguments[0])}, `
             );
 
         return [
@@ -122,7 +126,7 @@ export const create = (context) => ({
           ),
           fixer.replaceText(
             node.parent.parent.parent.arguments[0],
-            node.arguments[0].raw
+            context.getSourceCode().getText(node.arguments[0])
           ),
         ],
       });
@@ -148,7 +152,9 @@ export const create = (context) => ({
           ],
           `${
             node.parent.parent.property.name === "toBeFalsy" ? "not." : ""
-          }toHaveAttribute(${node.arguments[0].raw})`
+          }toHaveAttribute(${context
+            .getSourceCode()
+            .getText(node.arguments[0])})`
         ),
       ],
     });