Merge branch 'main' into support-additional-headers

Author: JoeDupuis

.github/workflows/test.yml

@@ -5,9 +5,6 @@ on:
   push:
     tags:
       - test
-    branches:
-      - '*'
-    pull_request:
 
 permissions:
   id-token: write
@@ -20,6 +17,16 @@ env:
   ARM_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
 
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+      - name: RuboCop
+        run: bundle exec rubocop
   deploy-infrastructure:
     runs-on: ubuntu-latest
     if: startsWith(github.ref, 'refs/tags/test')
@@ -113,7 +120,7 @@ jobs:
           AZURE_PRINCIPAL_ID: ${{ secrets.AZURE_PRINCIPAL_ID }}
         run: bundle exec rake test_azurite
 
-  test:
+  client_test:
     runs-on: ubuntu-latest
     steps:
       - name: Install dependencies
@@ -124,11 +131,32 @@ jobs:
         uses: ruby/setup-ruby@v1
         with:
           bundler-cache: true
-      - name: Tests
+      - name: Client tests
+        env:
+          AZURE_ACCOUNT_NAME: ${{secrets.AZURE_ACCOUNT_NAME}}
+          AZURE_ACCESS_KEY: ${{secrets.AZURE_ACCESS_KEY}}
+          AZURE_PRIVATE_CONTAINER: ${{secrets.AZURE_PRIVATE_CONTAINER}}
+          AZURE_PUBLIC_CONTAINER: ${{secrets.AZURE_PUBLIC_CONTAINER}}
+          AZURE_PRINCIPAL_ID: ${{secrets.AZURE_PRINCIPAL_ID}}
+        run: bundle exec rake test_client
+
+  rails_test:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Install dependencies
+        run: sudo apt-get install -y libvips sqlite3 libsqlite3-dev
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Setup ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+      - name: Rails tests
         env:
           AZURE_ACCOUNT_NAME: ${{secrets.AZURE_ACCOUNT_NAME}}
           AZURE_ACCESS_KEY: ${{secrets.AZURE_ACCESS_KEY}}
           AZURE_PRIVATE_CONTAINER: ${{secrets.AZURE_PRIVATE_CONTAINER}}
           AZURE_PUBLIC_CONTAINER: ${{secrets.AZURE_PUBLIC_CONTAINER}}
           AZURE_PRINCIPAL_ID: ${{secrets.AZURE_PRINCIPAL_ID}}
-        run: bundle exec rake test
+        run: bundle exec rake test_rails
+

CHANGELOG.md

@@ -1,6 +1,8 @@
 ## [Unreleased]
 
 - Add support for additional headers to all endpoints
+- Fix typo in class name `AzureBlob::ForbidenError` to `AzureBlob::ForbiddenError`
+- Fix proper URI encoding for keys with special characters like question marks
 
 ## [0.5.8] 2025-05-14
 

lib/azure_blob/http.rb

@@ -19,7 +19,7 @@ def inspect
       end
     end
     class FileNotFoundError < Error; end
-    class ForbidenError < Error; end
+    class ForbiddenError < Error; end
     class IntegrityError < Error; end
 
     include REXML
@@ -94,7 +94,7 @@ def success?
 
     ERROR_MAPPINGS = {
       Net::HTTPNotFound => FileNotFoundError,
-      Net::HTTPForbidden => ForbidenError,
+      Net::HTTPForbidden => ForbiddenError,
     }
 
     ERROR_CODE_MAPPINGS = {

test/client/test_client.rb

@@ -294,7 +294,7 @@ def test_read_only_signed_uri
       permissions: "r",
       expiry: Time.at(Time.now.to_i + EXPIRATION).utc.iso8601,
     )
-    assert_raises(AzureBlob::Http::ForbidenError) do
+    assert_raises(AzureBlob::Http::ForbiddenError) do
       AzureBlob::Http.new(uri, { "x-ms-blob-type": "BlockBlob" }).put(content)
     end