Remove extra validation + Improve testing

Author: Tranquility2

modules/generic/testcontainers/generic/sql.py

@@ -67,30 +67,16 @@ def _create_connection_url(
         if self._container is None:
             raise ContainerStartException("Container has not been started")
 
-        # Validate required parameters
-        if not dialect:
-            raise ValueError("Database dialect is required")
-        if not username:
-            raise ValueError("Database username is required")
-        if port is None:
-            raise ValueError("Database port is required")
-
         host = host or self.get_container_host_ip()
         exposed_port = self.get_exposed_port(port)
-
-        # Safely quote password to handle special characters
         quoted_password = quote(password, safe="")
         quoted_username = quote(username, safe="")
-
-        # Build base URL
         url = f"{dialect}://{quoted_username}:{quoted_password}@{host}:{exposed_port}"
 
-        # Add database name if provided
         if dbname:
             quoted_dbname = quote(dbname, safe="")
             url = f"{url}/{quoted_dbname}"
 
-        # Add query parameters if provided
         if query_params:
             query_string = urlencode(query_params)
             url = f"{url}?{query_string}"

modules/generic/tests/test_sql.py

@@ -1,4 +1,5 @@
 import pytest
+from unittest.mock import patch
 
 from testcontainers.core.exceptions import ContainerStartException
 from testcontainers.generic.sql import SqlContainer
@@ -96,21 +97,20 @@ def test_connection_url_with_query_params(self):
         assert "ssl=require" in url
         assert "timeout=30" in url
 
-    def test_connection_url_validation_errors(self):
+    def test_connection_url_type_errors(self):
+        """Test that _create_connection_url raises TypeError with invalid types"""
         container = SimpleSqlContainer()
-        container._container = type("MockContainer", (), {})()
-
-        # Test missing dialect
-        with pytest.raises(ValueError, match="Database dialect is required"):
-            container._create_connection_url("", "user", "pass", port=5432)
+        container._container = type("MockContainer", (), {"id": "test-id"})()
 
-        # Test missing username
-        with pytest.raises(ValueError, match="Database username is required"):
-            container._create_connection_url("postgresql", "", "pass", port=5432)
+        # Mock get_exposed_port to simulate what happens with None port
+        with patch.object(container, "get_exposed_port") as mock_get_port:
+            # Simulate the TypeError that would occur when int(None) is called
+            mock_get_port.side_effect = TypeError(
+                "int() argument must be a string, a bytes-like object or a real number, not 'NoneType'"
+            )
 
-        # Test missing port
-        with pytest.raises(ValueError, match="Database port is required"):
-            container._create_connection_url("postgresql", "user", "pass", port=None)
+            with pytest.raises(TypeError, match="int\\(\\) argument must be a string"):
+                container._create_connection_url("postgresql", "user", "pass", port=None)
 
     def test_connection_url_container_not_started(self):
         container = SimpleSqlContainer()