Fix: deleted default constructors do not allow serialization (#600)

Author: rjoomen

tesseract_motion_planners/trajopt_ifopt/include/tesseract_motion_planners/trajopt_ifopt/profile/trajopt_ifopt_osqp_solver_profile.h

@@ -29,17 +29,13 @@
 #include <tesseract_common/macros.h>
 TESSERACT_COMMON_IGNORE_WARNINGS_PUSH
 #include <memory>
+#include <OsqpEigen/Settings.hpp>
 #include <trajopt_sqp/fwd.h>
 #include <trajopt_sqp/types.h>
 TESSERACT_COMMON_IGNORE_WARNINGS_POP
 
 #include <tesseract_motion_planners/trajopt_ifopt/profile/trajopt_ifopt_profile.h>
 
-namespace OsqpEigen
-{
-class Settings;
-}
-
 namespace boost::serialization
 {
 template <class Archive>
@@ -60,11 +56,6 @@ class TrajOptIfoptOSQPSolverProfile : public TrajOptIfoptSolverProfile
   using ConstPtr = std::shared_ptr<const TrajOptIfoptOSQPSolverProfile>;
 
   TrajOptIfoptOSQPSolverProfile();
-  ~TrajOptIfoptOSQPSolverProfile() override;
-  TrajOptIfoptOSQPSolverProfile(const TrajOptIfoptOSQPSolverProfile&) = delete;
-  TrajOptIfoptOSQPSolverProfile& operator=(const TrajOptIfoptOSQPSolverProfile&) = delete;
-  TrajOptIfoptOSQPSolverProfile(TrajOptIfoptOSQPSolverProfile&&) = delete;
-  TrajOptIfoptOSQPSolverProfile&& operator=(TrajOptIfoptOSQPSolverProfile&&) = delete;
 
   /** @brief The OSQP convex solver settings to use */
   std::unique_ptr<OsqpEigen::Settings> qp_settings{ nullptr };

tesseract_motion_planners/trajopt_ifopt/src/profile/trajopt_ifopt_osqp_solver_profile.cpp

@@ -26,7 +26,6 @@
 
 #include <tesseract_common/macros.h>
 TESSERACT_COMMON_IGNORE_WARNINGS_PUSH
-#include <OsqpEigen/Settings.hpp>
 #include <OsqpEigen/OsqpEigen.h>
 #include <trajopt_sqp/trust_region_sqp_solver.h>
 #include <trajopt_sqp/osqp_eigen_solver.h>
@@ -107,8 +106,6 @@ TrajOptIfoptOSQPSolverProfile::TrajOptIfoptOSQPSolverProfile()
   qp_settings->setRelativeTolerance(1e-6);
 }
 
-TrajOptIfoptOSQPSolverProfile::~TrajOptIfoptOSQPSolverProfile() = default;
-
 std::unique_ptr<trajopt_sqp::TrustRegionSQPSolver> TrajOptIfoptOSQPSolverProfile::create(bool verbose) const
 {
   // Create QP Solver