Replace Ruby SDK models with official Smithy repository #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from AWS SDK Ruby models to official Smithy API models repository. See: https://github.com/aws/api-models-aws Related to #893
- Implement Smithy shape converter to handle traits-based format - Add service namespace resolution for qualified shape lookups - Implement staged pattern transformation with practical compatibility - Handle both enum-as-trait and enum-as-type formats - Sort enum values for deterministic output Key design decisions: - Prioritize clean, documented pattern transforms over exhaustive mapping - Accept some breaking changes for simpler architecture - Maintain critical ARN and validation pattern compatibility
- Remove deprecated attributes no longer in Terraform AWS provider: - aws_instance: cpu_core_count, cpu_threads_per_core - aws_launch_template: elastic_inference_accelerator, elastic_gpu_specifications - aws_spot_instance_request: block_duration_minutes - aws_eks_addon: resolve_conflicts - aws_redshift_cluster: snapshot_copy, logging (block types) - aws_ssm_association: instance_id - aws_flow_log: log_group_name - aws_eip: vpc - aws_dms_endpoint: s3_settings (block type) - Remove entire opsworks.hcl mapping (all OpsWorks resources removed from provider) - Successfully generate all rule files from Smithy API models - New rules added: aws_ecs_account_setting_default, aws_guardduty_member, aws_route53_record_invalid_zone_id - All enum values now alphabetically sorted for deterministic output
Pattern transforms are now working correctly:
- Cognito SMS message patterns properly transformed from ^\{####\}$ to ^.*\{####\}.*$
- All pattern compatibility transforms applied correctly
- All tests passing
bendrucker
force-pushed
the
convert-smithy-models-repo
branch
from
bd85770 to
5327171
Compare
- Remove unnecessary pattern fallbacks (no longer present in Smithy models)
- Add type-safe Smithy shape parsing with dedicated structs
- Replace map[string]interface{} casting with JSON unmarshaling
- Reduce potential panic points from ~20 type assertions to 0
All tests passing. No functional changes to generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the AWS SDK Ruby models with the official AWS Smithy API models repository. This enables access to the latest API definitions and removes the dependency on the Ruby SDK, which was included solely for the API models rather than the SDK itself.
Changes
Submodule migration: Replace
aws-sdk-rubywithaws/api-models-awsrepositoryaws-sdk-ruby/apis/apigateway/.../api-2.json→api-models-aws/models/api-gateway/.../api-gateway-....jsonGenerator enhancements: Add Smithy format support with type safety
namespace#ShapeName).*suffix to match role paths in Terraform configs{####}placeholderResource cleanup: Remove deprecated resources and attributes
Generated output changes:
aws_ecs_account_setting_default_invalid_name,aws_guardduty_member_invalid_email,aws_route53_record_invalid_zone_idBreaking Changes
Validation Changes (More Strict)
These rules now enforce stricter validation that may reject previously accepted values:
Cognito SMS messages (
aws_cognito_user_pool_invalid_sms_authentication_message,aws_cognito_user_pool_invalid_sms_verification_message):{####}placeholder within message text, not as standalone value"Your code is {####}"is valid, but"{####}"alone is notName validation patterns: Various EC2/ECS resource name patterns now correctly enforce end-of-string validation
$anchorDeviceFarm ARN patterns: Now enforce complete ARN format with proper termination
These changes reflect the authoritative patterns from AWS's official Smithy models.
References
Closes #893
Closes #900