Remove deprecated attributes and generate rules from Smithy models

- Remove deprecated attributes no longer in Terraform AWS provider:
  - aws_instance: cpu_core_count, cpu_threads_per_core
  - aws_launch_template: elastic_inference_accelerator, elastic_gpu_specifications
  - aws_spot_instance_request: block_duration_minutes
  - aws_eks_addon: resolve_conflicts
  - aws_redshift_cluster: snapshot_copy, logging (block types)
  - aws_ssm_association: instance_id
  - aws_flow_log: log_group_name
  - aws_eip: vpc
  - aws_dms_endpoint: s3_settings (block type)

- Remove entire opsworks.hcl mapping (all OpsWorks resources removed from provider)

- Successfully generate all rule files from Smithy API models
- New rules added: aws_ecs_account_setting_default, aws_guardduty_member, aws_route53_record_invalid_zone_id
- All enum values now alphabetically sorted for deterministic output

Author: bendrucker

docs/rules/README.md

@@ -517,14 +517,6 @@ These rules enforce best practices and naming conventions:
 |aws_dms_endpoint_invalid_endpoint_type|✔|
 |aws_dms_endpoint_invalid_ssl_mode|✔|
 |aws_dms_replication_task_invalid_migration_type|✔|
-|aws_dms_s3_endpoint_invalid_canned_acl_for_objects|✔|
-|aws_dms_s3_endpoint_invalid_compression_type|✔|
-|aws_dms_s3_endpoint_invalid_data_format|✔|
-|aws_dms_s3_endpoint_invalid_date_partition_delimiter|✔|
-|aws_dms_s3_endpoint_invalid_date_partition_sequence|✔|
-|aws_dms_s3_endpoint_invalid_encoding_type|✔|
-|aws_dms_s3_endpoint_invalid_encryption_mode|✔|
-|aws_dms_s3_endpoint_invalid_parquet_version|✔|
 |aws_docdb_global_cluster_invalid_global_cluster_identifier|✔|
 |aws_dx_bgp_peer_invalid_address_family|✔|
 |aws_dx_hosted_private_virtual_interface_invalid_address_family|✔|
@@ -574,6 +566,7 @@ These rules enforce best practices and naming conventions:
 |aws_ecrpublic_repository_invalid_repository_name|✔|
 |aws_ecrpublic_repository_policy_invalid_policy|✔|
 |aws_ecrpublic_repository_policy_invalid_repository_name|✔|
+|aws_ecs_account_setting_default_invalid_name|✔|
 |aws_ecs_service_invalid_launch_type|✔|
 |aws_ecs_service_invalid_propagate_tags|✔|
 |aws_ecs_service_invalid_scheduling_strategy|✔|
@@ -713,6 +706,7 @@ These rules enforce best practices and naming conventions:
 |aws_guardduty_ipset_invalid_location|✔|
 |aws_guardduty_ipset_invalid_name|✔|
 |aws_guardduty_member_invalid_detector_id|✔|
+|aws_guardduty_member_invalid_email|✔|
 |aws_guardduty_organization_configuration_invalid_detector_id|✔|
 |aws_guardduty_publishing_destination_invalid_destination_type|✔|
 |aws_guardduty_publishing_destination_invalid_detector_id|✔|
@@ -1023,6 +1017,7 @@ These rules enforce best practices and naming conventions:
 |aws_route53_record_invalid_name|✔|
 |aws_route53_record_invalid_set_identifier|✔|
 |aws_route53_record_invalid_type|✔|
+|aws_route53_record_invalid_zone_id|✔|
 |aws_route53_resolver_dnssec_config_invalid_resource_id|✔|
 |aws_route53_resolver_endpoint_invalid_direction|✔|
 |aws_route53_resolver_firewall_config_invalid_firewall_fail_open|✔|

rules/models/aws_accessanalyzer_analyzer_invalid_type.go

@@ -26,11 +26,11 @@ func NewAwsAccessanalyzerAnalyzerInvalidTypeRule() *AwsAccessanalyzerAnalyzerInv
 		attributeName: "type",
 		enum: []string{
 			"ACCOUNT",
-			"ORGANIZATION",
-			"ACCOUNT_UNUSED_ACCESS",
-			"ORGANIZATION_UNUSED_ACCESS",
 			"ACCOUNT_INTERNAL_ACCESS",
+			"ACCOUNT_UNUSED_ACCESS",
+			"ORGANIZATION",
 			"ORGANIZATION_INTERNAL_ACCESS",
+			"ORGANIZATION_UNUSED_ACCESS",
 		},
 	}
 }

rules/models/aws_acmpca_certificate_invalid_signing_algorithm.go

@@ -25,11 +25,14 @@ func NewAwsAcmpcaCertificateInvalidSigningAlgorithmRule() *AwsAcmpcaCertificateI
 		resourceType:  "aws_acmpca_certificate",
 		attributeName: "signing_algorithm",
 		enum: []string{
+			"ML_DSA_44",
+			"ML_DSA_65",
+			"ML_DSA_87",
 			"SHA256WITHECDSA",
-			"SHA384WITHECDSA",
-			"SHA512WITHECDSA",
 			"SHA256WITHRSA",
+			"SHA384WITHECDSA",
 			"SHA384WITHRSA",
+			"SHA512WITHECDSA",
 			"SHA512WITHRSA",
 			"SM3WITHSM2",
 		},

rules/models/aws_alb_invalid_ip_address_type.go

@@ -25,9 +25,9 @@ func NewAwsALBInvalidIPAddressTypeRule() *AwsALBInvalidIPAddressTypeRule {
 		resourceType:  "aws_alb",
 		attributeName: "ip_address_type",
 		enum: []string{
-			"ipv4",
 			"dualstack",
 			"dualstack-without-public-ipv4",
+			"ipv4",
 		},
 	}
 }

rules/models/aws_alb_invalid_load_balancer_type.go

@@ -26,8 +26,8 @@ func NewAwsALBInvalidLoadBalancerTypeRule() *AwsALBInvalidLoadBalancerTypeRule {
 		attributeName: "load_balancer_type",
 		enum: []string{
 			"application",
-			"network",
 			"gateway",
+			"network",
 		},
 	}
 }

rules/models/aws_alb_listener_invalid_protocol.go

@@ -25,13 +25,13 @@ func NewAwsALBListenerInvalidProtocolRule() *AwsALBListenerInvalidProtocolRule {
 		resourceType:  "aws_alb_listener",
 		attributeName: "protocol",
 		enum: []string{
+			"GENEVE",
 			"HTTP",
 			"HTTPS",
 			"TCP",
+			"TCP_UDP",
 			"TLS",
 			"UDP",
-			"TCP_UDP",
-			"GENEVE",
 		},
 	}
 }

rules/models/aws_alb_target_group_invalid_protocol.go

@@ -25,13 +25,13 @@ func NewAwsALBTargetGroupInvalidProtocolRule() *AwsALBTargetGroupInvalidProtocol
 		resourceType:  "aws_alb_target_group",
 		attributeName: "protocol",
 		enum: []string{
+			"GENEVE",
 			"HTTP",
 			"HTTPS",
 			"TCP",
+			"TCP_UDP",
 			"TLS",
 			"UDP",
-			"TCP_UDP",
-			"GENEVE",
 		},
 	}
 }

rules/models/aws_alb_target_group_invalid_target_type.go

@@ -25,10 +25,10 @@ func NewAwsALBTargetGroupInvalidTargetTypeRule() *AwsALBTargetGroupInvalidTarget
 		resourceType:  "aws_alb_target_group",
 		attributeName: "target_type",
 		enum: []string{
+			"alb",
 			"instance",
 			"ip",
 			"lambda",
-			"alb",
 		},
 	}
 }

rules/models/aws_ami_invalid_architecture.go

@@ -25,11 +25,11 @@ func NewAwsAMIInvalidArchitectureRule() *AwsAMIInvalidArchitectureRule {
 		resourceType:  "aws_ami",
 		attributeName: "architecture",
 		enum: []string{
+			"arm64",
+			"arm64_mac",
 			"i386",
 			"x86_64",
-			"arm64",
 			"x86_64_mac",
-			"arm64_mac",
 		},
 	}
 }

rules/models/aws_amplify_app_invalid_platform.go

@@ -26,8 +26,8 @@ func NewAwsAmplifyAppInvalidPlatformRule() *AwsAmplifyAppInvalidPlatformRule {
 		attributeName: "platform",
 		enum: []string{
 			"WEB",
-			"WEB_DYNAMIC",
 			"WEB_COMPUTE",
+			"WEB_DYNAMIC",
 		},
 	}
 }